Module Name: src Committed By: hannken Date: Thu Aug 29 06:43:13 UTC 2019
Modified Files: src/sys/miscfs/kernfs: kernfs_vnops.c src/sys/miscfs/procfs: procfs_vnops.c Log Message: Add missing operation VOP_GETPAGES() returning EFAULT. Without this operation posix_fadvise(..., POSIX_FADV_WILLNEED) would leave the v_interlock held. Observed by maxv@ To generate a diff of this commit: cvs rdiff -u -r1.160 -r1.161 src/sys/miscfs/kernfs/kernfs_vnops.c cvs rdiff -u -r1.206 -r1.207 src/sys/miscfs/procfs/procfs_vnops.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Modified files: Index: src/sys/miscfs/kernfs/kernfs_vnops.c diff -u src/sys/miscfs/kernfs/kernfs_vnops.c:1.160 src/sys/miscfs/kernfs/kernfs_vnops.c:1.161 --- src/sys/miscfs/kernfs/kernfs_vnops.c:1.160 Mon Sep 3 16:29:35 2018 +++ src/sys/miscfs/kernfs/kernfs_vnops.c Thu Aug 29 06:43:13 2019 @@ -1,4 +1,4 @@ -/* $NetBSD: kernfs_vnops.c,v 1.160 2018/09/03 16:29:35 riastradh Exp $ */ +/* $NetBSD: kernfs_vnops.c,v 1.161 2019/08/29 06:43:13 hannken Exp $ */ /* * Copyright (c) 1992, 1993 @@ -39,7 +39,7 @@ */ #include <sys/cdefs.h> -__KERNEL_RCSID(0, "$NetBSD: kernfs_vnops.c,v 1.160 2018/09/03 16:29:35 riastradh Exp $"); +__KERNEL_RCSID(0, "$NetBSD: kernfs_vnops.c,v 1.161 2019/08/29 06:43:13 hannken Exp $"); #include <sys/param.h> #include <sys/systm.h> @@ -172,6 +172,7 @@ int kernfs_print(void *); int kernfs_pathconf(void *); #define kernfs_advlock genfs_einval #define kernfs_bwrite genfs_eopnotsupp +int kernfs_getpages(void *); #define kernfs_putpages genfs_putpages static int kernfs_xread(struct kernfs_node *, int, char **, @@ -219,6 +220,7 @@ const struct vnodeopv_entry_desc kernfs_ { &vop_pathconf_desc, kernfs_pathconf }, /* pathconf */ { &vop_advlock_desc, kernfs_advlock }, /* advlock */ { &vop_bwrite_desc, kernfs_bwrite }, /* bwrite */ + { &vop_getpages_desc, kernfs_getpages }, /* getpages */ { &vop_putpages_desc, kernfs_putpages }, /* putpages */ { NULL, NULL } }; @@ -1169,3 +1171,23 @@ kernfs_symlink(void *v) VOP_ABORTOP(ap->a_dvp, ap->a_cnp); return (EROFS); } + +int +kernfs_getpages(void *v) +{ + struct vop_getpages_args /* { + struct vnode *a_vp; + voff_t a_offset; + struct vm_page **a_m; + int *a_count; + int a_centeridx; + vm_prot_t a_access_type; + int a_advice; + int a_flags; + } */ *ap = v; + + if ((ap->a_flags & PGO_LOCKED) == 0) + mutex_exit(ap->a_vp->v_interlock); + + return (EFAULT); +} Index: src/sys/miscfs/procfs/procfs_vnops.c diff -u src/sys/miscfs/procfs/procfs_vnops.c:1.206 src/sys/miscfs/procfs/procfs_vnops.c:1.207 --- src/sys/miscfs/procfs/procfs_vnops.c:1.206 Sat Mar 30 23:28:30 2019 +++ src/sys/miscfs/procfs/procfs_vnops.c Thu Aug 29 06:43:13 2019 @@ -1,4 +1,4 @@ -/* $NetBSD: procfs_vnops.c,v 1.206 2019/03/30 23:28:30 christos Exp $ */ +/* $NetBSD: procfs_vnops.c,v 1.207 2019/08/29 06:43:13 hannken Exp $ */ /*- * Copyright (c) 2006, 2007, 2008 The NetBSD Foundation, Inc. @@ -105,7 +105,7 @@ */ #include <sys/cdefs.h> -__KERNEL_RCSID(0, "$NetBSD: procfs_vnops.c,v 1.206 2019/03/30 23:28:30 christos Exp $"); +__KERNEL_RCSID(0, "$NetBSD: procfs_vnops.c,v 1.207 2019/08/29 06:43:13 hannken Exp $"); #include <sys/param.h> #include <sys/systm.h> @@ -243,6 +243,7 @@ int procfs_pathconf(void *); #define procfs_islocked genfs_islocked #define procfs_advlock genfs_einval #define procfs_bwrite genfs_eopnotsupp +int procfs_getpages(void *); #define procfs_putpages genfs_null_putpages static int atoi(const char *, size_t); @@ -291,6 +292,7 @@ const struct vnodeopv_entry_desc procfs_ { &vop_islocked_desc, procfs_islocked }, /* islocked */ { &vop_pathconf_desc, procfs_pathconf }, /* pathconf */ { &vop_advlock_desc, procfs_advlock }, /* advlock */ + { &vop_getpages_desc, procfs_getpages }, /* getpages */ { &vop_putpages_desc, procfs_putpages }, /* putpages */ { NULL, NULL } }; @@ -1719,6 +1721,26 @@ procfs_readlink(void *v) return error; } +int +procfs_getpages(void *v) +{ + struct vop_getpages_args /* { + struct vnode *a_vp; + voff_t a_offset; + struct vm_page **a_m; + int *a_count; + int a_centeridx; + vm_prot_t a_access_type; + int a_advice; + int a_flags; + } */ *ap = v; + + if ((ap->a_flags & PGO_LOCKED) == 0) + mutex_exit(ap->a_vp->v_interlock); + + return (EFAULT); +} + /* * convert decimal ascii to int */