On Mon, Sep 02, 2019 at 08:18:06AM -0000, Christos Zoulas wrote: > >> b) Rename upper-case'd file to another name e.g.: foo_bar_old.bin > >> > >> pros: It can be keep the driver's behavior the same as linux's. > >> cons: We have to modify many files and lines. > >> If we support new kernel + old filesystem, we should > >> modify > >> the driver to load FOO_BAR.bin first and then > >FOO_BAR_old.bin. > > This is the most intrusive option. Even if you choose to do "d" as I describe > below, it is probably preferrable to change the filename from: > > radeon/FOO_bar.bin and radeon/foo_bar.bin to > radeon/FOO_bar.bin and radeon/new/foo_bar.bin > > There are only 2 files that need the change and due to excessive cut-n-pasting > there are a bunch of snprintf's that need modifying (the ones that contain > new_chip_name in src/sys/external/bsd/drm2/dist/drm/radeon: radeon_si.c > and radeon_cik.c)
Can we bring this up upstream and ask them to rename? Martin
