Module Name: src
Committed By: msaitoh
Date: Wed Sep 18 00:09:42 UTC 2019
Modified Files:
src/sys/dev/pci: if_lii.c
Log Message:
Use unsigned to avoid undefined behavior in lii_setmulti().
To generate a diff of this commit:
cvs rdiff -u -r1.26 -r1.27 src/sys/dev/pci/if_lii.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/pci/if_lii.c
diff -u src/sys/dev/pci/if_lii.c:1.26 src/sys/dev/pci/if_lii.c:1.27
--- src/sys/dev/pci/if_lii.c:1.26 Thu May 30 02:32:18 2019
+++ src/sys/dev/pci/if_lii.c Wed Sep 18 00:09:42 2019
@@ -1,4 +1,4 @@
-/* $NetBSD: if_lii.c,v 1.26 2019/05/30 02:32:18 msaitoh Exp $ */
+/* $NetBSD: if_lii.c,v 1.27 2019/09/18 00:09:42 msaitoh Exp $ */
/*
* Copyright (c) 2008 The NetBSD Foundation.
@@ -31,7 +31,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_lii.c,v 1.26 2019/05/30 02:32:18 msaitoh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_lii.c,v 1.27 2019/09/18 00:09:42 msaitoh Exp $");
#include <sys/param.h>
@@ -1186,10 +1186,10 @@ lii_setmulti(struct lii_softc *sc)
crc = ether_crc32_be(enm->enm_addrlo, ETHER_ADDR_LEN);
- if (crc & (1 << 31))
- mht1 |= (1 << ((crc >> 26) & 0x0000001f));
+ if (crc & (1U << 31))
+ mht1 |= (1U << ((crc >> 26) & 0x0000001f));
else
- mht0 |= (1 << ((crc >> 26) & 0x0000001f));
+ mht0 |= (1U << ((crc >> 26) & 0x0000001f));
ETHER_NEXT_MULTI(step, enm);
}
