>>> Joerg Sonnenberger <jo...@bec.de> wrote > On Thu, Nov 21, 2019 at 11:06:16PM +0000, Takeshi Nakayama wrote: > > Module Name: src > > Committed By: nakayama > > Date: Thu Nov 21 23:06:16 UTC 2019 > > > > Modified Files: > > src/lib/libc/tls: tls.c > > > > Log Message: > > Fix PR/54074 and PR/54093 completely. > > > > More similar to the ld.elf_so logic, it is necessary to align with > > p_align first. Also, invert the #ifdef condition for consistency. > > This commit just wastes space without reason.
No, without this commit the TLS offset calculation is mismatch if alignof(max_align_t)) != p_align. -- Takeshi Nakayama