On Sat, 23 Nov 2019 19:53:05 +0100, "Jared D. McNeill" wrote: > > Module Name: src > Committed By: jmcneill > Date: Sat Nov 23 18:53:05 UTC 2019 > > Modified Files: > src/sys/dev/fdt: fdt_port.c > > Log Message: > Use fdtbus_get_reg to read "reg" property
Hi, this change breaks the build (of earmv7hf) on FreeBSD: /usr/home/herbert/source/netbsd/current/src/sys/dev/fdt/fdt_port.c: In function 'fdt_ports_register': /usr/home/herbert/source/netbsd/current/src/sys/dev/fdt/fdt_port.c:299:32: error: passing argument 3 of 'fdtbus_get_reg' from incompatible pointer type [-Werror=incompatible-pointer-types] if (fdtbus_get_reg(child, 0, &id, NULL) != 0) { ^~~ In file included from /usr/home/herbert/source/netbsd/current/src/sys/dev/fdt/fdt_port.c:49: /usr/home/herbert/source/netbsd/current/src/sys/dev/fdt/fdtvar.h:303:33: note: expected 'bus_addr_t *' {aka 'long unsigned int *'} but argument is of type 'uint64_t *' {aka 'long long unsigned int *'} int fdtbus_get_reg(int, u_int, bus_addr_t *, bus_size_t *); ^~~~~~~~~~~~ -- Herbert