LGTM too. christos
> On Jan 12, 2020, at 10:09 AM, Jason Thorpe <thor...@me.com> wrote: > > > >> On Jan 11, 2020, at 10:47 PM, Izumi Tsutsui <tsut...@ceres.dti.ne.jp> wrote: >> >> thorpej@ wrote: >> >>>> PGSHIFT is defined in <machine/param.h> and >>>> PAGE_SHIFT and PAGE_SIZE is in <machine/vmparam.h>, >>>> but there is no common <m68k/vmparam.h>. >>> >>> Make a common <m68k/vmparam.h> that all of the platforms can #include, and >>> just put these common definitions in it (for now)? >> >> How about the attached diff? (untested, just for review) > > This looks good to me. > > -- thorpej
signature.asc
Description: Message signed with OpenPGP
