On 2020/01/10 15:59, Jason Thorpe wrote: > > >> On Jan 9, 2020, at 9:02 PM, Masanobu SAITOH <msai...@execsw.org> wrote: >> >> The reason why I moved stge_softc to if_stgereg.h was that ipgphy.c >> required to check stge's chip revision. So, if there is no any objection, >> I'll make new if_stgevar.h and share it with if_stge.c and ipgphy.c. > > That seems fine. Although it might be preferable to set a property on the > parent dev_t and then query that from ipgphy,
I've changed by this way. If it use if_stgevar.h and it includes pci related header file, some archs' kernel which use ipgphy and not use PCI can't be compiled. Some other MII PHY drivers do so. Thanks. > rather than accessing the softc. > > -- thorpej > -- ----------------------------------------------- SAITOH Masanobu (msai...@execsw.org msai...@netbsd.org)