Re: slk.c still broken on some architecetures

[Paul Goyette]

On Thu, 24 Jun 2021, Martin Husemann wrote:

On Thu, Jun 24, 2021 at 08:33:45AM -0700, Paul Goyette wrote:
/build/netbsd-current/src_ro/lib/libcurses/slk.c: In function '__slk_wset':
/build/netbsd-current/src_ro/lib/libcurses/slk.c:571:52: error: format '%ld' 
expects argument of type 'long int', but argument 3 has type 'size_t' {aka 
'unsigned int'} [-Werror=format=]
  571 |  __CTRACE(__CTRACE_INPUT, "__slk_wset: wcsrtombs %ld\n", len);
      |                                                  ~~^     ~~~
      |                                                    |     |
      |                                                    |     size_t {aka 
unsigned int}
      |                                                    long int
      |                                                  %d

I fixed that printf format, but the code should not be enabled in default
builds (it is #ifdef DEBUG). Somehow you must have enabled that DEBUG code.

Oooppss!  I had disabled MKDEBUG and MKKDEBUG, but I forgot to disable 
MKDEBUGLIB (these are enabled by default in my build.sh wrapper).

Thanks for fixing.


+--------------------+--------------------------+----------------------+
| Paul Goyette       | PGP Key fingerprint:     | E-mail addresses:    |
| (Retired)          | FA29 0E3B 35AF E8AE 6651 | p...@whooppee.com    |
| Software Developer | 0786 F758 55DE 53BA 7731 | pgoye...@netbsd.org  |
|                    |                          | pgoyett...@gmail.com |
+--------------------+--------------------------+----------------------+