I guess I should revert this particular change then. Yes, I saw PGOFSET definition and assumed it's a typo too, just too widely used and like you said historical value. In some header files PGOFSET had a comment: "byte offset into page" next to it.
On Sun, Jul 25, 2021, 00:53 Izumi Tsutsui <tsut...@ceres.dti.ne.jp> wrote: > > Log Message: > > Fix all remaining typos, mainly in comments but also in few definitions > and log messages, reported by me in PR kern/54889. > > Also fixed some additional typos in comments, found on review of same > files or typos. > : > > cvs rdiff -u -r1.51 -r1.52 src/sys/arch/sh3/sh3/exception_vector.S > > cvs rdiff -u -r1.83 -r1.84 src/sys/arch/sh3/sh3/pmap.c > > --- > #define __PMAP_PTP_PG_N (PAGE_SIZE / sizeof(pt_entry_t)) > #define __PMAP_PTP_INDEX(va) (((va) >> __PMAP_PTP_SHIFT) & > (__PMAP_PTP_N - 1)) > -#define __PMAP_PTP_OFSET(va) ((va >> PGSHIFT) & > (__PMAP_PTP_PG_N - 1)) > +#define __PMAP_PTP_OFFSET(va) ((va >> PGSHIFT) & > (__PMAP_PTP_PG_N - 1)) > --- > > This "OFSET" seems corresponding to historical MI "PGOFSET" macro defined > in <machine/param.h> (though I don't know if the "OFSET" had particular > meanings, other than its strlen). > > --- > Izumi Tsutsui >
