Module Name: src
Committed By: rillig
Date: Sun Oct 10 08:35:34 UTC 2021
Modified Files:
src/bin/sh: Makefile jobs.c
Log Message:
sh: remove no-op 'continue' from do-while-0 loop
With Clang, the only change to the binary are the line number changes
from __LINE__, GCC generates a bit different code.
No functional change.
To generate a diff of this commit:
cvs rdiff -u -r1.119 -r1.120 src/bin/sh/Makefile
cvs rdiff -u -r1.112 -r1.113 src/bin/sh/jobs.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/bin/sh/Makefile
diff -u src/bin/sh/Makefile:1.119 src/bin/sh/Makefile:1.120
--- src/bin/sh/Makefile:1.119 Sat Oct 9 21:06:31 2021
+++ src/bin/sh/Makefile Sun Oct 10 08:35:34 2021
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.119 2021/10/09 21:06:31 rillig Exp $
+# $NetBSD: Makefile,v 1.120 2021/10/10 08:35:34 rillig Exp $
# @(#)Makefile 8.4 (Berkeley) 5/5/95
.include <bsd.own.mk>
@@ -30,7 +30,6 @@ CPPFLAGS+= -DUSE_LRAND48
#COPTS+=-g
#CFLAGS+=-funsigned-char
#TARGET_CHARFLAG?= -DTARGET_CHAR="unsigned char" -funsigned-char
-LINTFLAGS+= -X 323 # continue in 'do ... while (0)' loop
# Reproducible build parameters ... export into sh for NETBSD_SHELL setting
.if ${MKREPRO_TIMESTAMP:Uno} != "no"
Index: src/bin/sh/jobs.c
diff -u src/bin/sh/jobs.c:1.112 src/bin/sh/jobs.c:1.113
--- src/bin/sh/jobs.c:1.112 Sun Sep 12 01:30:41 2021
+++ src/bin/sh/jobs.c Sun Oct 10 08:35:34 2021
@@ -1,4 +1,4 @@
-/* $NetBSD: jobs.c,v 1.112 2021/09/12 01:30:41 kre Exp $ */
+/* $NetBSD: jobs.c,v 1.113 2021/10/10 08:35:34 rillig Exp $ */
/*-
* Copyright (c) 1991, 1993
@@ -37,7 +37,7 @@
#if 0
static char sccsid[] = "@(#)jobs.c 8.5 (Berkeley) 5/4/95";
#else
-__RCSID("$NetBSD: jobs.c,v 1.112 2021/09/12 01:30:41 kre Exp $");
+__RCSID("$NetBSD: jobs.c,v 1.113 2021/10/10 08:35:34 rillig Exp $");
#endif
#endif /* not lint */
@@ -196,10 +196,8 @@ setjobctl(int on)
}
if (initialpgrp == -1)
initialpgrp = getpgrp();
- else if (initialpgrp != getpgrp()) {
+ else if (initialpgrp != getpgrp())
killpg(0, SIGTTIN);
- continue;
- }
} while (0);
#ifdef OLD_TTY_DRIVER