I think you're misreading the diff - it will only wrap if the minimum size is 0xffffffff, which is...ummm...highly unlikely (it's defined to be 0 right now, the type is unsigned)
On Thu, 4 Nov 2021 at 15:56, Joerg Sonnenberger <jo...@bec.de> wrote: > On Mon, Nov 01, 2021 at 03:09:59AM +0000, Alistair G. Crooks wrote: > > Module Name: src > > Committed By: agc > > Date: Mon Nov 1 03:09:59 UTC 2021 > > > > Modified Files: > > src/external/apache2/argon2/dist/phc-winner-argon2/src: argon2.c > core.c > > src/lib/libcrypt: Makefile > > > > Log Message: > > Remove the > > > > COPTS.*+= -Wno-error=.* > > > > lines for building argon2 sources, by fixing the problems at source. > > > > Addresses Rin Okuyama's concerns on tech-userlevel/tech-crypto in > > > > Message-ID: <f1eab199-3607-bb05-15cc-033e38721...@gmail.com> > > The +1 part seems questionable to me as it can actually introduce a wrap > around, can't it? > > Joerg > >
