Module Name: src Committed By: rillig Date: Sun Nov 7 13:38:32 UTC 2021
Modified Files: src/usr.bin/indent: pr_comment.c Log Message: indent: remove code that accessed out-of-bounds data from buffer Saving and restoring the exact buffer position had been necessary before NetBSD pr_comment.c 1.114. The code accessed the buffer data out of the bounds of [com.s, com.e), which was rather surprising. More specifically, it accessed com.e[-1] in a case where com.e == com.s, relying on com.e[-1] being ' ' in most cases and '*' in the case where the comment delimiter was written to a separate output line. Make the code easier understandable by only ever accessing the buffer data in the bounds [buf.s, buf.e). No functional change. To generate a diff of this commit: cvs rdiff -u -r1.114 -r1.115 src/usr.bin/indent/pr_comment.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.