Module Name: src
Committed By: riastradh
Date: Thu Mar 3 05:52:55 UTC 2022
Modified Files:
src/sys/dev/usb: if_aue.c
Log Message:
aue(4): Reduce aue_uno_mcast from aue_uno_init to aue_setiff_locked.
This operation only needs to update the hardware to reflect
SIOCADDMULTI/SIOCDELMULTI. Not clear that everything in aue(4) needs
to be reset -- in fact I'm pretty sure that's undesirable!
WARNING: I have not tested this with a real aue(4) device.
To generate a diff of this commit:
cvs rdiff -u -r1.177 -r1.178 src/sys/dev/usb/if_aue.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/usb/if_aue.c
diff -u src/sys/dev/usb/if_aue.c:1.177 src/sys/dev/usb/if_aue.c:1.178
--- src/sys/dev/usb/if_aue.c:1.177 Thu Mar 3 05:52:46 2022
+++ src/sys/dev/usb/if_aue.c Thu Mar 3 05:52:55 2022
@@ -1,4 +1,4 @@
-/* $NetBSD: if_aue.c,v 1.177 2022/03/03 05:52:46 riastradh Exp $ */
+/* $NetBSD: if_aue.c,v 1.178 2022/03/03 05:52:55 riastradh Exp $ */
/*
* Copyright (c) 1997, 1998, 1999, 2000
@@ -76,7 +76,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_aue.c,v 1.177 2022/03/03 05:52:46 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_aue.c,v 1.178 2022/03/03 05:52:55 riastradh Exp $");
#ifdef _KERNEL_OPT
#include "opt_usb.h"
@@ -1009,11 +1009,7 @@ aue_uno_mcast(struct ifnet *ifp)
device_unit(((struct usbnet *)(ifp->if_softc))->un_dev),
0, 0, 0);
- /*
- * XXX I feel like this is pretty heavy-handed! Maybe we could
- * make do with aue_setiff_locked instead?
- */
- aue_uno_init(ifp);
+ aue_setiff_locked(ifp);
}
static void
