Am 24.03.2022 um 17:15 schrieb Christos Zoulas:
Module Name: src Committed By: christos Date: Thu Mar 24 16:15:05 UTC 2022Modified Files: src/lib/libc/time: localtime.c Log Message: put back the 2022a changes and fix the misplaced brace. To generate a diff of this commit: cvs rdiff -u -r1.128 -r1.129 src/lib/libc/time/localtime.c
The indentation of this file looks completely random: Line 272 has a comment indented by 2 spaces, the code in that block is indented by 4 spaces instead of the usual tab. Same for line 295. Line 350 is indented differently than line 346. Line 420 has a continuation that is indented by 2 spaces instead of the usual 4. Line 490 is indented by 2 spaces instead of the usual tab. Line 513 is indented by 4 spaces instead of the usual tab. Line 534 is indented by 2 spaces instead of the usual tab. Line 585 is indented by 2 spaces instead of the usual tab. Line 667 is indented by 2 tabs instead of the usual 1 tab. Line 683 is indented by 2 tabs instead of the usual tab. Line 688 is indented by 2 spaces instead of the usual tab. Line 1083 contains unaligned variable declarations. Line 2347 looks as if it were assuming a tab width of 4, but the immediately following line breaks this assumption. Someone should clean up this mess. I don't know how good the test coverage for localtime(3) is, so I'm happy to leave this (and a few possible refactorings to decrease the indentation) to people more familiar with the history and origins of this file. Roland
