Module Name: src
Committed By: riastradh
Date: Mon Mar 28 12:37:35 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Assert opencnt is nonzero before decrementing.
To generate a diff of this commit:
cvs rdiff -u -r1.206 -r1.207 src/sys/miscfs/specfs/spec_vnops.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/miscfs/specfs/spec_vnops.c
diff -u src/sys/miscfs/specfs/spec_vnops.c:1.206 src/sys/miscfs/specfs/spec_vnops.c:1.207
--- src/sys/miscfs/specfs/spec_vnops.c:1.206 Mon Mar 28 12:37:26 2022
+++ src/sys/miscfs/specfs/spec_vnops.c Mon Mar 28 12:37:35 2022
@@ -1,4 +1,4 @@
-/* $NetBSD: spec_vnops.c,v 1.206 2022/03/28 12:37:26 riastradh Exp $ */
+/* $NetBSD: spec_vnops.c,v 1.207 2022/03/28 12:37:35 riastradh Exp $ */
/*-
* Copyright (c) 2008 The NetBSD Foundation, Inc.
@@ -58,7 +58,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: spec_vnops.c,v 1.206 2022/03/28 12:37:26 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: spec_vnops.c,v 1.207 2022/03/28 12:37:35 riastradh Exp $");
#include <sys/param.h>
#include <sys/proc.h>
@@ -944,6 +944,8 @@ spec_open(void *v)
KASSERT(sn->sn_opencnt == 1);
needclose = true;
} else {
+ KASSERT(sd->sd_opencnt);
+ KASSERT(sn->sn_opencnt);
sd->sd_opencnt--;
sn->sn_opencnt--;
if (vp->v_type == VBLK)
@@ -1643,6 +1645,8 @@ spec_close(void *v)
* between open and close can use fd_clone.
*/
mutex_enter(&device_lock);
+ KASSERT(sn->sn_opencnt);
+ KASSERT(sd->sd_opencnt);
sn->sn_opencnt--;
count = --sd->sd_opencnt;
if (vp->v_type == VBLK) {
