Module Name:    src
Committed By:   riastradh
Date:           Sat Apr  9 23:45:14 UTC 2022

Modified Files:
        src/sys/rump/librump/rumpkern: scheduler.c

Log Message:
rumpkern/scheduler: Use membar_release.

...but add an XXX comment asking for clarity on what it pairs with.


To generate a diff of this commit:
cvs rdiff -u -r1.52 -r1.53 src/sys/rump/librump/rumpkern/scheduler.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/rump/librump/rumpkern/scheduler.c
diff -u src/sys/rump/librump/rumpkern/scheduler.c:1.52 src/sys/rump/librump/rumpkern/scheduler.c:1.53
--- src/sys/rump/librump/rumpkern/scheduler.c:1.52	Sun Nov  1 20:58:38 2020
+++ src/sys/rump/librump/rumpkern/scheduler.c	Sat Apr  9 23:45:14 2022
@@ -1,4 +1,4 @@
-/*      $NetBSD: scheduler.c,v 1.52 2020/11/01 20:58:38 christos Exp $	*/
+/*      $NetBSD: scheduler.c,v 1.53 2022/04/09 23:45:14 riastradh Exp $	*/
 
 /*
  * Copyright (c) 2010, 2011 Antti Kantee.  All Rights Reserved.
@@ -26,7 +26,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: scheduler.c,v 1.52 2020/11/01 20:58:38 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: scheduler.c,v 1.53 2022/04/09 23:45:14 riastradh Exp $");
 
 #include <sys/param.h>
 #include <sys/atomic.h>
@@ -473,7 +473,7 @@ rump_unschedule_cpu1(struct lwp *l, void
 	if (interlock == rcpu->rcpu_mtx)
 		rumpuser_mutex_enter_nowrap(rcpu->rcpu_mtx);
 	else
-		membar_exit();
+		membar_release(); /* XXX what does this pair with? */
 
 	/* Release the CPU. */
 	old = atomic_swap_ptr(&rcpu->rcpu_prevlwp, l);

Reply via email to