Yes -- I suppose genfs_pathconf() is sufficient here. -- J. Hannken-Illjes - hann...@mailbox.org
> On 3. Oct 2022, at 11:40, Frank Kardel <kar...@kardel.name> wrote: > > > Good to know. So do we need to add path conf there? > Frank > > 3 Oct 2022 11:34:09 J. Hannken-Illjes <hann...@mailbox.org>: > >> Frank, >> >> the vnode operations for ".zfs" are in zfs_ctldir.c and there >> is no pathconf operation here ... >> >> -- >> J. Hannken-Illjes - hann...@mailbox.org >> >>> On 3. Oct 2022, at 11:26, Frank Kardel <kar...@kardel.name> wrote: >>> >>> Well, I am am happy to do that. But ls got eopnotsupp for fpathconf of ACL >>> names and barked at them when listing the .zfs snapshot directory. Ls is >>> only ignoring einval at that place. So something must be wrong there wrt >>> tog. >>> Frank >>> >>> 3 Oct 2022 10:53:10 J. Hannken-Illjes <hann...@mailbox.org>: >>> >>>>> On 27. Sep 2022, at 12:33, Frank Kardel <kar...@netbsd.org> wrote: >>>>> >>>>> Module Name: src >>>>> Committed By: kardel >>>>> Date: Tue Sep 27 10:33:21 UTC 2022 >>>>> >>>>> Modified Files: >>>>> src/external/cddl/osnet/dist/uts/common/fs/zfs: zfs_vnops.c >>>>> >>>>> Log Message: >>>>> for unsupported names return EINVAL as per TOG >>>>> https://pubs.opengroup.org/onlinepubs/9699919799/functions/fpathconf.html >>>>> discussed with christos@ >>>>> >>>>> >>>>> To generate a diff of this commit: >>>>> cvs rdiff -u -r1.78 -r1.79 \ >>>>> src/external/cddl/osnet/dist/uts/common/fs/zfs/zfs_vnops.c >>>> >>>> This is completely wrong! >>>> >>>> The call sequence is "VOP_PATHCONF -> zfs_netbsd_pathconf -> zfs_pathconf" >>>> where zfs_netbsd_pathconf() handles the NetBSD specific names if >>>> zfs_pathconf() returns EOPNOTSUPP and also returns EINVAL for >>>> unsupported names in this case. >>>> >>>> Please revert. >>>> >>>> -- >>>> J. Hannken-Illjes - hann...@mailbox.org
signature.asc
Description: Message signed with OpenPGP
