Hi, Taylor R Campbell <campbell+netbsd-source-change...@mumble.net> writes:
>> Date: Tue, 04 Oct 2022 15:53:58 +0900 >> From: Ryo ONODERA <r...@tetera.org> >> >> With this patch, it works fine for me. >> There is no stall after genfb(4). >> And I do not find any other problem so far. > > Thanks! There probably is another problem which is that kernel > console printfs might stop appearing after a certain point, which the > following patch might fix too -- I inadvertently reversed the sense > of a conditional in the subr_prf.c changes. I have not encountered another problem yet. However with your consprintfix.patch, it works fine for me too. Thank you. > From 0f058a0e89e3f545a9020a2fb79dadd7ad89029a Mon Sep 17 00:00:00 2001 > From: Taylor R Campbell <riastr...@netbsd.org> > Date: Tue, 4 Oct 2022 05:48:39 +0000 > Subject: [PATCH] squash! constty(4): Make MP-safe. > > - Fix reversed sense of conditional. > --- > sys/kern/subr_prf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sys/kern/subr_prf.c b/sys/kern/subr_prf.c > index e87e6efc8501..53fb20c1d393 100644 > --- a/sys/kern/subr_prf.c > +++ b/sys/kern/subr_prf.c > @@ -425,7 +425,7 @@ putone(int c, int flags, struct tty *tp) > if ((flags & TOLOG) && > c != '\0' && c != '\r' && c != 0177) > logputchar(c); > - if ((flags & TOCONS) && ctp != NULL && c != '\0') > + if ((flags & TOCONS) && ctp == NULL && c != '\0') > (*v_putc)(c); > > pserialize_read_exit(s); -- Ryo ONODERA // r...@tetera.org PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB FD1B F404 27FA C7D1 15F3