Module Name: src
Committed By: rillig
Date: Sat Jul 8 12:45:43 UTC 2023
Modified Files:
src/tests/usr.bin/xlint/lint1: platform_lp64.c
src/usr.bin/xlint/lint1: tree.c
Log Message:
lint: warn about conversion from 128-bit to smaller integer types
To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 src/tests/usr.bin/xlint/lint1/platform_lp64.c
cvs rdiff -u -r1.551 -r1.552 src/usr.bin/xlint/lint1/tree.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/tests/usr.bin/xlint/lint1/platform_lp64.c
diff -u src/tests/usr.bin/xlint/lint1/platform_lp64.c:1.6 src/tests/usr.bin/xlint/lint1/platform_lp64.c:1.7
--- src/tests/usr.bin/xlint/lint1/platform_lp64.c:1.6 Sat Jul 8 12:42:11 2023
+++ src/tests/usr.bin/xlint/lint1/platform_lp64.c Sat Jul 8 12:45:43 2023
@@ -1,4 +1,4 @@
-/* $NetBSD: platform_lp64.c,v 1.6 2023/07/08 12:42:11 rillig Exp $ */
+/* $NetBSD: platform_lp64.c,v 1.7 2023/07/08 12:45:43 rillig Exp $ */
# 3 "platform_lp64.c"
/*
@@ -39,7 +39,8 @@ convert_unsigned_char_to_size_t(unsigned
void
convert_128(void)
{
- /* TODO: Warn about 128-bit types as well. */
+ /* expect+1: warning: conversion from '__int128_t' to 'int' may lose accuracy [132] */
s32 = s128;
+ /* expect+1: warning: conversion from '__uint128_t' to 'unsigned int' may lose accuracy [132] */
u32 = u128;
}
Index: src/usr.bin/xlint/lint1/tree.c
diff -u src/usr.bin/xlint/lint1/tree.c:1.551 src/usr.bin/xlint/lint1/tree.c:1.552
--- src/usr.bin/xlint/lint1/tree.c:1.551 Sat Jul 8 12:07:21 2023
+++ src/usr.bin/xlint/lint1/tree.c Sat Jul 8 12:45:43 2023
@@ -1,4 +1,4 @@
-/* $NetBSD: tree.c,v 1.551 2023/07/08 12:07:21 rillig Exp $ */
+/* $NetBSD: tree.c,v 1.552 2023/07/08 12:45:43 rillig Exp $ */
/*
* Copyright (c) 1994, 1995 Jochen Pohl
@@ -37,7 +37,7 @@
#include <sys/cdefs.h>
#if defined(__RCSID)
-__RCSID("$NetBSD: tree.c,v 1.551 2023/07/08 12:07:21 rillig Exp $");
+__RCSID("$NetBSD: tree.c,v 1.552 2023/07/08 12:45:43 rillig Exp $");
#endif
#include <float.h>
@@ -3447,8 +3447,7 @@ convert_integer_from_integer(op_t op, in
if (aflag > 0 &&
portable_rank_cmp(nt, ot) < 0 &&
- (ot == LONG || ot == ULONG || ot == LLONG || ot == ULLONG ||
- aflag > 1) &&
+ (portable_rank_cmp(ot, LONG) >= 0 || aflag > 1) &&
// XXX: The portable_rank_cmp above aims at portable mode,
// independent of the current platform, while can_represent acts
// on the actual types from the current platform. This mix is
