Module Name: src
Committed By: simonb
Date: Mon Nov 20 03:05:48 UTC 2023
Modified Files:
src/sys/arch/amd64/amd64: process_machdep.c
src/sys/arch/amd64/include: ptrace.h
src/sys/arch/i386/i386: process_machdep.c
src/sys/arch/i386/include: ptrace.h
Log Message:
Note some large xstate stack objects what Somebody(tm) should look at
when they find some round tuits.
To generate a diff of this commit:
cvs rdiff -u -r1.49 -r1.50 src/sys/arch/amd64/amd64/process_machdep.c
cvs rdiff -u -r1.22 -r1.23 src/sys/arch/amd64/include/ptrace.h
cvs rdiff -u -r1.96 -r1.97 src/sys/arch/i386/i386/process_machdep.c
cvs rdiff -u -r1.26 -r1.27 src/sys/arch/i386/include/ptrace.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/arch/amd64/amd64/process_machdep.c
diff -u src/sys/arch/amd64/amd64/process_machdep.c:1.49 src/sys/arch/amd64/amd64/process_machdep.c:1.50
--- src/sys/arch/amd64/amd64/process_machdep.c:1.49 Mon Oct 19 17:47:37 2020
+++ src/sys/arch/amd64/amd64/process_machdep.c Mon Nov 20 03:05:48 2023
@@ -1,4 +1,4 @@
-/* $NetBSD: process_machdep.c,v 1.49 2020/10/19 17:47:37 christos Exp $ */
+/* $NetBSD: process_machdep.c,v 1.50 2023/11/20 03:05:48 simonb Exp $ */
/*
* Copyright (c) 1998, 2000 The NetBSD Foundation, Inc.
@@ -74,7 +74,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: process_machdep.c,v 1.49 2020/10/19 17:47:37 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: process_machdep.c,v 1.50 2023/11/20 03:05:48 simonb Exp $");
#ifdef _KERNEL_OPT
#include "opt_xen.h"
@@ -396,7 +396,7 @@ process_machdep_doxstate(struct lwp *cur
/* l: traced */
{
int error;
- struct xstate r;
+ struct xstate r; /* XXX FIXME big stack object */
char *kv;
ssize_t kl;
Index: src/sys/arch/amd64/include/ptrace.h
diff -u src/sys/arch/amd64/include/ptrace.h:1.22 src/sys/arch/amd64/include/ptrace.h:1.23
--- src/sys/arch/amd64/include/ptrace.h:1.22 Sat May 30 08:41:22 2020
+++ src/sys/arch/amd64/include/ptrace.h Mon Nov 20 03:05:48 2023
@@ -1,4 +1,4 @@
-/* $NetBSD: ptrace.h,v 1.22 2020/05/30 08:41:22 maxv Exp $ */
+/* $NetBSD: ptrace.h,v 1.23 2023/11/20 03:05:48 simonb Exp $ */
/*
* Copyright (c) 1993 Christopher G. Demetriou
@@ -117,7 +117,7 @@ MODULE_HOOK(netbsd32_process_doxmmregs_h
#define PT64_GETXSTATE PT_GETXSTATE
#define COREDUMP_MACHDEP_LWP_NOTES(l, ns, name) \
{ \
- struct xstate xstate; \
+ struct xstate xstate; /* XXX FIXME big stack object */ \
memset(&xstate, 0, sizeof(xstate)); \
if (!process_read_xstate(l, &xstate)) \
{ \
Index: src/sys/arch/i386/i386/process_machdep.c
diff -u src/sys/arch/i386/i386/process_machdep.c:1.96 src/sys/arch/i386/i386/process_machdep.c:1.97
--- src/sys/arch/i386/i386/process_machdep.c:1.96 Mon Oct 19 17:47:37 2020
+++ src/sys/arch/i386/i386/process_machdep.c Mon Nov 20 03:05:48 2023
@@ -1,4 +1,4 @@
-/* $NetBSD: process_machdep.c,v 1.96 2020/10/19 17:47:37 christos Exp $ */
+/* $NetBSD: process_machdep.c,v 1.97 2023/11/20 03:05:48 simonb Exp $ */
/*-
* Copyright (c) 1998, 2000, 2001, 2008 The NetBSD Foundation, Inc.
@@ -75,7 +75,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: process_machdep.c,v 1.96 2020/10/19 17:47:37 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: process_machdep.c,v 1.97 2023/11/20 03:05:48 simonb Exp $");
#ifdef _KERNEL_OPT
#include "opt_ptrace.h"
@@ -408,7 +408,7 @@ process_machdep_doxstate(struct lwp *cur
/* l: traced */
{
int error;
- struct xstate r;
+ struct xstate r; /* XXX FIXME big stack object */
char *kv;
ssize_t kl;
Index: src/sys/arch/i386/include/ptrace.h
diff -u src/sys/arch/i386/include/ptrace.h:1.26 src/sys/arch/i386/include/ptrace.h:1.27
--- src/sys/arch/i386/include/ptrace.h:1.26 Sat May 30 08:41:23 2020
+++ src/sys/arch/i386/include/ptrace.h Mon Nov 20 03:05:48 2023
@@ -1,4 +1,4 @@
-/* $NetBSD: ptrace.h,v 1.26 2020/05/30 08:41:23 maxv Exp $ */
+/* $NetBSD: ptrace.h,v 1.27 2023/11/20 03:05:48 simonb Exp $ */
/*
* Copyright (c) 2001 Wasabi Systems, Inc.
@@ -162,7 +162,7 @@
#define PT32_GETXSTATE PT_GETXSTATE
#define COREDUMP_MACHDEP_LWP_NOTES(l, ns, name) \
{ \
- struct xstate xstate; \
+ struct xstate xstate; /* XXX FIXME big stack object */ \
memset(&xstate, 0, sizeof(xstate)); \
if (!process_read_xstate(l, &xstate)) \
{ \
