Module Name:    src
Committed By:   pgoyette
Date:           Thu Dec  7 16:47:44 UTC 2023

Modified Files:
        src/sys/netinet6: in6.c

Log Message:
Identify the need to rework the COMPAT_* code to be more
module-aware.

This is an XXX comment block only, NFCI.


To generate a diff of this commit:
cvs rdiff -u -r1.289 -r1.290 src/sys/netinet6/in6.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/netinet6/in6.c
diff -u src/sys/netinet6/in6.c:1.289 src/sys/netinet6/in6.c:1.290
--- src/sys/netinet6/in6.c:1.289	Thu Aug  3 05:44:22 2023
+++ src/sys/netinet6/in6.c	Thu Dec  7 16:47:44 2023
@@ -1,4 +1,4 @@
-/*	$NetBSD: in6.c,v 1.289 2023/08/03 05:44:22 ozaki-r Exp $	*/
+/*	$NetBSD: in6.c,v 1.290 2023/12/07 16:47:44 pgoyette Exp $	*/
 /*	$KAME: in6.c,v 1.198 2001/07/18 09:12:38 itojun Exp $	*/
 
 /*
@@ -62,7 +62,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: in6.c,v 1.289 2023/08/03 05:44:22 ozaki-r Exp $");
+__KERNEL_RCSID(0, "$NetBSD: in6.c,v 1.290 2023/12/07 16:47:44 pgoyette Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_inet.h"
@@ -105,6 +105,17 @@ __KERNEL_RCSID(0, "$NetBSD: in6.c,v 1.28
 #include <netinet6/in6_ifattach.h>
 #include <netinet6/scope6_var.h>
 
+/* XXX
+ *
+ * The COMPAT_* code here, along with call-sites in nd6.c and
+ * icmp6.c, needs to be reworked to use compat hooks.  As it
+ * stands right now, the compat code only gets built if it is
+ * iincluded in the kernel at build time;  building and loading
+ * compat_* modules will not include this compat code!
+ *
+ * XXX
+ */
+
 #ifdef COMPAT_50
 #include <compat/netinet6/in6_var.h>
 #endif

Reply via email to