Module Name: src
Committed By: riastradh
Date: Thu Mar 21 02:35:09 UTC 2024
Modified Files:
src/sys/dev/acpi: apei_einj.c apei_hest.c
Log Message:
apei(4): Note some TODOs for EINJ and HEST.
No functional change intended, comments only.
PR kern/58046
To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/sys/dev/acpi/apei_einj.c \
src/sys/dev/acpi/apei_hest.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/acpi/apei_einj.c
diff -u src/sys/dev/acpi/apei_einj.c:1.2 src/sys/dev/acpi/apei_einj.c:1.3
--- src/sys/dev/acpi/apei_einj.c:1.2 Thu Mar 21 02:34:59 2024
+++ src/sys/dev/acpi/apei_einj.c Thu Mar 21 02:35:09 2024
@@ -1,4 +1,4 @@
-/* $NetBSD: apei_einj.c,v 1.2 2024/03/21 02:34:59 riastradh Exp $ */
+/* $NetBSD: apei_einj.c,v 1.3 2024/03/21 02:35:09 riastradh Exp $ */
/*-
* Copyright (c) 2024 The NetBSD Foundation, Inc.
@@ -38,10 +38,13 @@
* some nontrivial userland support; maybe relying on the user to tread
* carefully with error injection is fine -- after all, many types of
* error injection will cause a system halt/panic.
+ *
+ * XXX Properly expose SET_ERROR_TYPE_WITH_ADDRESS, which has a more
+ * complicated relationship with its RegisterRegion field.
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: apei_einj.c,v 1.2 2024/03/21 02:34:59 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: apei_einj.c,v 1.3 2024/03/21 02:35:09 riastradh Exp $");
#include <sys/types.h>
Index: src/sys/dev/acpi/apei_hest.c
diff -u src/sys/dev/acpi/apei_hest.c:1.2 src/sys/dev/acpi/apei_hest.c:1.3
--- src/sys/dev/acpi/apei_hest.c:1.2 Wed Mar 20 18:47:59 2024
+++ src/sys/dev/acpi/apei_hest.c Thu Mar 21 02:35:09 2024
@@ -1,4 +1,4 @@
-/* $NetBSD: apei_hest.c,v 1.2 2024/03/20 18:47:59 riastradh Exp $ */
+/* $NetBSD: apei_hest.c,v 1.3 2024/03/21 02:35:09 riastradh Exp $ */
/*-
* Copyright (c) 2024 The NetBSD Foundation, Inc.
@@ -43,10 +43,16 @@
*
* XXX sort out interrupt notification types, e.g. do we ever need to
* do acpi_intr_establish?
+ *
+ * XXX sysctl knob to force polling each particular error source that
+ * supports it
+ *
+ * XXX consider a lighter-weight polling schedule for machines with
+ * thousands of polled GHESes
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: apei_hest.c,v 1.2 2024/03/20 18:47:59 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: apei_hest.c,v 1.3 2024/03/21 02:35:09 riastradh Exp $");
#include <sys/types.h>
