Date: Thu, 18 Apr 2024 19:23:54 +0000 From: "Jonathan A. Kollasch" <jakll...@netbsd.org> Message-ID: <20240418192354.1bcc1f...@cvs.netbsd.org>
| Module Name: src | Committed By: jakllsch | Date: Thu Apr 18 19:23:54 UTC 2024 | | Modified Files: | src/external/bsd/ntp/lib/libntp: Makefile | | Log Message: | Format MKREPRO_TIMESTAMP with "%b %d %Y" to correctly substitute __DATE__ I don't understand that change, it altered from MKREPRO_DATE != ${TOOL_DATE} -u -r "${MKREPRO_TIMESTAMP}" "+%F" to MKREPRO_DATE != ${TOOL_DATE} -u -r "${MKREPRO_TIMESTAMP}" "+%b %d %Y" %F is simply a shorthand for %Y-%m-%d (which is the correct way to write locale independent dates), %b is a locale dependent name of the month, and what's more this is in US-centric mon day year format, which we should avoid (aside from anything else, it is a dumb format, with the smallest value unit sitting in the middle, rather than at one end or the other). If there is a problem where support for %F is missing somewhere, (and if that happens in TOOL_DATE it must mean that we're using a locale strftime() when building it, in which case we should add our version to the library) please replace it with %Y-%m-%d (which is what it is defined to be) instead of anything using %b (or %a or %B or %A) (or any other weird formats). Further, if some format like that was needed for some reason, then it probably should use %e rather than %d (to suppress the leading 0 on dates before the 10th). But don't just do that either. If there isn't an actual problem using %F, please just revert this. And lastly, and this applies to everyone - please do not request pullups of anything (except perhaps urgent security fixes) immediately after the change is committed - give it at least a few days, in case of objection, breakage, ... kre