Module Name:    src
Committed By:   riastradh
Date:           Fri Jul 26 18:29:50 UTC 2024

Modified Files:
        src/sys/external/isc/libsodium/include: core.h

Log Message:
sys/crypto/sodium: Nix risky defines from core.h stub.

These are risky not because they might cause crypto flaws, but
because they might cause usage of the SIMD unit in the kernel along
paths where we haven't made it safe.

That said -- no change to the amd64 module .o and .kmod files, so
this doesn't currently make a difference; it's just risky to have
around in case we later include other parts of libsodium that it does
affect, like the Salsa20 code.

PR kern/58468


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/sys/external/isc/libsodium/include/core.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/external/isc/libsodium/include/core.h
diff -u src/sys/external/isc/libsodium/include/core.h:1.1 src/sys/external/isc/libsodium/include/core.h:1.2
--- src/sys/external/isc/libsodium/include/core.h:1.1	Thu Aug 20 21:20:16 2020
+++ src/sys/external/isc/libsodium/include/core.h	Fri Jul 26 18:29:50 2024
@@ -2,11 +2,3 @@
 
 #include "../dist/src/libsodium/include/sodium/export.h"
 #define sodium_misuse()	panic("sodium_misuse")
-
-#ifdef __x86_64__
-/* From Makefile generated by libsodium/configure on NetBSD/amd64 */
-#define HAVE_AMD64_ASM	1
-//#define HAVE_AVX_ASM	1
-#define HAVE_CPUID	1
-//#define HAVE_TI_MODE	1
-#endif

Reply via email to