Module Name: src
Committed By: skrll
Date: Sun Sep 15 09:46:45 UTC 2024
Modified Files:
src/sys/net: if_gif.c
Log Message:
Drop locks before freeing unreferenced memory in gif_set_tunnel
To generate a diff of this commit:
cvs rdiff -u -r1.158 -r1.159 src/sys/net/if_gif.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/net/if_gif.c
diff -u src/sys/net/if_gif.c:1.158 src/sys/net/if_gif.c:1.159
--- src/sys/net/if_gif.c:1.158 Sat Feb 10 18:43:53 2024
+++ src/sys/net/if_gif.c Sun Sep 15 09:46:45 2024
@@ -1,4 +1,4 @@
-/* $NetBSD: if_gif.c,v 1.158 2024/02/10 18:43:53 andvar Exp $ */
+/* $NetBSD: if_gif.c,v 1.159 2024/09/15 09:46:45 skrll Exp $ */
/* $KAME: if_gif.c,v 1.76 2001/08/20 02:01:02 kjc Exp $ */
/*
@@ -31,7 +31,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_gif.c,v 1.158 2024/02/10 18:43:53 andvar Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_gif.c,v 1.159 2024/09/15 09:46:45 skrll Exp $");
#ifdef _KERNEL_OPT
#include "opt_inet.h"
@@ -1160,12 +1160,13 @@ gif_set_tunnel(struct ifnet *ifp, struct
return 0;
out:
+ mutex_exit(&sc->gif_lock);
+ encap_lock_exit();
+
sockaddr_free(nsrc);
sockaddr_free(ndst);
kmem_free(nvar, sizeof(*nvar));
- mutex_exit(&sc->gif_lock);
- encap_lock_exit();
#ifndef GIF_MPSAFE
splx(s);
#endif
