no, i did not. I will fix asap. christos
> On Oct 6, 2024, at 7:59 PM, Taylor R Campbell <riastr...@netbsd.org> wrote: > > >> >> Module Name: src >> Committed By: christos >> Date: Thu Oct 3 16:50:52 UTC 2024 >> >> Modified Files: >> src/sys/kern: syscalls.master sysv_sem.c >> src/sys/sys: sem.h >> >> Log Message: >> Add semtimedop GSoC 2024 (Shivraj Jamgade) > > This doesn't seem to pass the existing sysv semaphore tests: > > https://releng.netbsd.org/b5reports/i386/2024/2024.10.03.16.54.08/test.html#kernel_t_sysv_sem > https://mail-index.netbsd.org/current-users/2024/10/04/msg045666.html > > Did you run the tests before committing? > > None of the new tests seem to be passing either: > > https://releng.netbsd.org/b5reports/i386/2024/2024.10.04.05.56.03/test.html#failed-tcs-summary > > semtimedop_basic: > /tmp/build/2024.10.04.05.56.03-i386/src/tests/kernel/t_semtimedop.c:77: > semtimedop failed: Invalid argument > semtimedop_invalid: > /tmp/build/2024.10.04.05.56.03-i386/src/tests/kernel/t_semtimedop.c:249: > semtimedop did not fail on invalid sem_num > semtimedop_timeout: > /tmp/build/2024.10.04.05.56.03-i386/src/tests/kernel/t_semtimedop.c:142: > WEXITSTATUS(status) != 0
