Module Name:    src
Committed By:   snj
Date:           Tue Mar 24 20:29:53 UTC 2009

Modified Files:
        src/sys/fs/udf [netbsd-5]: udf_vnops.c

Log Message:
Pull up following revision(s) (requested by reinoud in ticket #592):
        sys/fs/udf/udf_vnops.c: revision 1.38
Fix panic due to memory leak on symlink creation. A test copy with 3000+
symlinks could get the machine down.


To generate a diff of this commit:
cvs rdiff -u -r1.30.4.5 -r1.30.4.6 src/sys/fs/udf/udf_vnops.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/fs/udf/udf_vnops.c
diff -u src/sys/fs/udf/udf_vnops.c:1.30.4.5 src/sys/fs/udf/udf_vnops.c:1.30.4.6
--- src/sys/fs/udf/udf_vnops.c:1.30.4.5	Wed Mar 18 21:13:01 2009
+++ src/sys/fs/udf/udf_vnops.c	Tue Mar 24 20:29:53 2009
@@ -1,4 +1,4 @@
-/* $NetBSD: udf_vnops.c,v 1.30.4.5 2009/03/18 21:13:01 snj Exp $ */
+/* $NetBSD: udf_vnops.c,v 1.30.4.6 2009/03/24 20:29:53 snj Exp $ */
 
 /*
  * Copyright (c) 2006, 2008 Reinoud Zandijk
@@ -32,7 +32,7 @@
 
 #include <sys/cdefs.h>
 #ifndef lint
-__KERNEL_RCSID(0, "$NetBSD: udf_vnops.c,v 1.30.4.5 2009/03/18 21:13:01 snj Exp $");
+__KERNEL_RCSID(0, "$NetBSD: udf_vnops.c,v 1.30.4.6 2009/03/24 20:29:53 snj Exp $");
 #endif /* not lint */
 
 
@@ -1668,13 +1668,10 @@
 		pathbuf, pathlen, 0,
 		UIO_SYSSPACE, IO_NODELOCKED | IO_ALTSEMANTICS,
 		FSCRED, NULL, NULL);
-	if (error) {
-		/* failed to write out symlink contents */
-		free(pathbuf, M_UDFTEMP);
-		return error;
-	}
 
-	return 0;
+	/* return status of symlink contents writeout */
+	free(pathbuf, M_UDFTEMP);
+	return error;
 }
 
 

Reply via email to