Module Name:    src
Committed By:   snj
Date:           Sat Apr  4 18:22:54 UTC 2009

Modified Files:
        src/sbin/ifconfig [netbsd-5]: ifconfig.c

Log Message:
Pull up following revision(s) (requested by plunky in ticket #665):
        sbin/ifconfig/ifconfig.c: revision 1.215
Because the IFF_NOARP flag is a negative option it needs to be negated
when being applied from the "arp" option which itself is positive.
problem demonstrated by
# ifconfig tap3 create
# ifconfig tap3
tap3: flags=8802<BROADCAST,SIMPLEX,MULTICAST> mtu 1500
        address: f2:0b:a4:7f:44:03
        media: Ethernet autoselect
# ifconfig tap3 arp
# ifconfig tap3
tap3: flags=8882<BROADCAST,NOARP,SIMPLEX,MULTICAST> mtu 1500
        address: f2:0b:a4:7f:44:03
        media: Ethernet autoselect
# ifconfig tap3 -arp
# ifconfig tap3
tap3: flags=8802<BROADCAST,SIMPLEX,MULTICAST> mtu 1500
        address: f2:0b:a4:7f:44:03
        media: Ethernet autoselect
# ifconfig tap3 destroy
#


To generate a diff of this commit:
cvs rdiff -u -r1.213 -r1.213.2.1 src/sbin/ifconfig/ifconfig.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sbin/ifconfig/ifconfig.c
diff -u src/sbin/ifconfig/ifconfig.c:1.213 src/sbin/ifconfig/ifconfig.c:1.213.2.1
--- src/sbin/ifconfig/ifconfig.c:1.213	Fri Aug  1 22:29:13 2008
+++ src/sbin/ifconfig/ifconfig.c	Sat Apr  4 18:22:54 2009
@@ -1,4 +1,4 @@
-/*	$NetBSD: ifconfig.c,v 1.213 2008/08/01 22:29:13 dyoung Exp $	*/
+/*	$NetBSD: ifconfig.c,v 1.213.2.1 2009/04/04 18:22:54 snj Exp $	*/
 
 /*-
  * Copyright (c) 1997, 1998, 2000 The NetBSD Foundation, Inc.
@@ -63,7 +63,7 @@
 #ifndef lint
 __COPYRIGHT("@(#) Copyright (c) 1983, 1993\
  The Regents of the University of California.  All rights reserved.");
-__RCSID("$NetBSD: ifconfig.c,v 1.213 2008/08/01 22:29:13 dyoung Exp $");
+__RCSID("$NetBSD: ifconfig.c,v 1.213.2.1 2009/04/04 18:22:54 snj Exp $");
 #endif /* not lint */
 
 #include <sys/param.h>
@@ -131,7 +131,7 @@
 static void usage(void);
 
 static const struct kwinst ifflagskw[] = {
-	  IFKW("arp", IFF_NOARP)
+	  IFKW("arp", -IFF_NOARP)
 	, IFKW("debug", IFF_DEBUG)
 	, IFKW("link0", IFF_LINK0)
 	, IFKW("link1", IFF_LINK1)

Reply via email to