Module Name: src Committed By: drochner Date: Tue Sep 15 19:41:30 UTC 2009
Modified Files: src/sys/dev/acpi/acpica: OsdHardware.c Log Message: fix undefined return values of Read/WriteMemory, found by clang static analyzer To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/sys/dev/acpi/acpica/OsdHardware.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Modified files: Index: src/sys/dev/acpi/acpica/OsdHardware.c diff -u src/sys/dev/acpi/acpica/OsdHardware.c:1.4 src/sys/dev/acpi/acpica/OsdHardware.c:1.5 --- src/sys/dev/acpi/acpica/OsdHardware.c:1.4 Wed Dec 12 23:33:22 2007 +++ src/sys/dev/acpi/acpica/OsdHardware.c Tue Sep 15 19:41:30 2009 @@ -1,4 +1,4 @@ -/* $NetBSD: OsdHardware.c,v 1.4 2007/12/12 23:33:22 jmcneill Exp $ */ +/* $NetBSD: OsdHardware.c,v 1.5 2009/09/15 19:41:30 drochner Exp $ */ /* * Copyright 2001 Wasabi Systems, Inc. @@ -44,7 +44,7 @@ */ #include <sys/cdefs.h> -__KERNEL_RCSID(0, "$NetBSD: OsdHardware.c,v 1.4 2007/12/12 23:33:22 jmcneill Exp $"); +__KERNEL_RCSID(0, "$NetBSD: OsdHardware.c,v 1.5 2009/09/15 19:41:30 drochner Exp $"); #include <sys/param.h> #include <sys/device.h> @@ -127,7 +127,7 @@ AcpiOsReadMemory(ACPI_PHYSICAL_ADDRESS Address, UINT32 *Value, UINT32 Width) { void *LogicalAddress; - ACPI_STATUS rv; + ACPI_STATUS rv = AE_OK; LogicalAddress = AcpiOsMapMemory(Address, Width / 8); if (LogicalAddress == NULL) @@ -164,7 +164,7 @@ AcpiOsWriteMemory(ACPI_PHYSICAL_ADDRESS Address, UINT32 Value, UINT32 Width) { void *LogicalAddress; - ACPI_STATUS rv; + ACPI_STATUS rv = AE_OK; LogicalAddress = AcpiOsMapMemory(Address, Width / 8); if (LogicalAddress == NULL)