Module Name: src
Committed By: hannken
Date: Tue Oct 13 12:37:19 UTC 2009
Modified Files:
src/sys/dev: fss.c
Log Message:
Fix a race where the backing store thread runs (and exits immediately)
before kthread_create() returns.
To generate a diff of this commit:
cvs rdiff -u -r1.63 -r1.64 src/sys/dev/fss.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/fss.c
diff -u src/sys/dev/fss.c:1.63 src/sys/dev/fss.c:1.64
--- src/sys/dev/fss.c:1.63 Mon Jun 29 05:08:17 2009
+++ src/sys/dev/fss.c Tue Oct 13 12:37:19 2009
@@ -1,4 +1,4 @@
-/* $NetBSD: fss.c,v 1.63 2009/06/29 05:08:17 dholland Exp $ */
+/* $NetBSD: fss.c,v 1.64 2009/10/13 12:37:19 hannken Exp $ */
/*-
* Copyright (c) 2003 The NetBSD Foundation, Inc.
@@ -36,7 +36,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: fss.c,v 1.63 2009/06/29 05:08:17 dholland Exp $");
+__KERNEL_RCSID(0, "$NetBSD: fss.c,v 1.64 2009/10/13 12:37:19 hannken Exp $");
#include <sys/param.h>
#include <sys/systm.h>
@@ -446,11 +446,12 @@
sc->sc_indir_data = NULL;
}
+ sc->sc_flags |= FSS_BS_THREAD;
if ((error = kthread_create(PRI_BIO, 0, NULL, fss_bs_thread, sc,
- &sc->sc_bs_lwp, device_xname(sc->sc_dev))) != 0)
+ &sc->sc_bs_lwp, device_xname(sc->sc_dev))) != 0) {
+ sc->sc_flags &= ~FSS_BS_THREAD;
return error;
-
- sc->sc_flags |= FSS_BS_THREAD;
+ }
disk_attach(sc->sc_dkdev);
