Module Name: src
Committed By: jdolecek
Date: Wed Oct 24 20:01:13 UTC 2018
Modified Files:
src/sys/dev/ata: ata.c
Log Message:
add further note about FIS-based switching to atastart()
To generate a diff of this commit:
cvs rdiff -u -r1.143 -r1.144 src/sys/dev/ata/ata.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/ata/ata.c
diff -u src/sys/dev/ata/ata.c:1.143 src/sys/dev/ata/ata.c:1.144
--- src/sys/dev/ata/ata.c:1.143 Wed Oct 24 19:38:00 2018
+++ src/sys/dev/ata/ata.c Wed Oct 24 20:01:13 2018
@@ -1,4 +1,4 @@
-/* $NetBSD: ata.c,v 1.143 2018/10/24 19:38:00 jdolecek Exp $ */
+/* $NetBSD: ata.c,v 1.144 2018/10/24 20:01:13 jdolecek Exp $ */
/*
* Copyright (c) 1998, 2001 Manuel Bouyer. All rights reserved.
@@ -25,7 +25,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ata.c,v 1.143 2018/10/24 19:38:00 jdolecek Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ata.c,v 1.144 2018/10/24 20:01:13 jdolecek Exp $");
#include "opt_ata.h"
@@ -1053,6 +1053,14 @@ ata_exec_xfer(struct ata_channel *chp, s
* are shared.
*
* MUST BE CALLED AT splbio()!
+ *
+ * XXX FIS-based switching with PMP
+ * Currently atastart() never schedules concurrent NCQ transfers to more than
+ * one drive, even when channel has several SATA drives attached via PMP.
+ * To support concurrent transfers to different drives with PMP, it would be
+ * necessary to implement FIS-based switching support in controller driver,
+ * and then adjust error handling and recovery to stop assuming at most
+ * one active drive.
*/
void
atastart(struct ata_channel *chp)
