Module Name: src
Committed By: pgoyette
Date: Wed Feb 20 04:32:51 UTC 2019
Modified Files:
src/doc: TODO.modules
Log Message:
Add an entry to remind someone(tm) to review the need for WARNS=3 in
more than 100 modules' Makefile.
To generate a diff of this commit:
cvs rdiff -u -r1.18 -r1.19 src/doc/TODO.modules
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/doc/TODO.modules
diff -u src/doc/TODO.modules:1.18 src/doc/TODO.modules:1.19
--- src/doc/TODO.modules:1.18 Fri Dec 28 21:51:49 2018
+++ src/doc/TODO.modules Wed Feb 20 04:32:51 2019
@@ -1,4 +1,4 @@
-/* $NetBSD: TODO.modules,v 1.18 2018/12/28 21:51:49 pgoyette Exp $ */
+/* $NetBSD: TODO.modules,v 1.19 2019/02/20 04:32:51 pgoyette Exp $ */
Some notes on the limitations of our current (as of 7.99.35) module
subsystem. This list was triggered by an Email exchange between
@@ -212,3 +212,10 @@ christos and pgoyette.
Additional difficulties arise when the module which defines the
weak symbol gets unloaded. Then, you would need to re-run the
linker and _unresolve_ the weak symbol which is no longer defined.
+
+22. A fairly large number of modules still require a maximum warning
+ level of WARNS=3 due to signed-vs-unsigned integer comparisons. We
+ really ought to clean these up. (I haven't looked at them in any
+ detail, but I have to wonder how code that compiles cleanly in a
+ normal kernel has these issues when compiled in a module, when both
+ are done with WARNS=5).
