Module Name: src Committed By: hannken Date: Sun Feb 24 16:11:24 UTC 2019
Modified Files: src/sys/kern: vfs_trans.c Log Message: Clear per-lwp entries whose mount is gone before the first return from fstrans_done(). No longer leaks "struct mount" forever. To generate a diff of this commit: cvs rdiff -u -r1.55 -r1.56 src/sys/kern/vfs_trans.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Modified files: Index: src/sys/kern/vfs_trans.c diff -u src/sys/kern/vfs_trans.c:1.55 src/sys/kern/vfs_trans.c:1.56 --- src/sys/kern/vfs_trans.c:1.55 Thu Feb 21 08:52:53 2019 +++ src/sys/kern/vfs_trans.c Sun Feb 24 16:11:24 2019 @@ -1,4 +1,4 @@ -/* $NetBSD: vfs_trans.c,v 1.55 2019/02/21 08:52:53 hannken Exp $ */ +/* $NetBSD: vfs_trans.c,v 1.56 2019/02/24 16:11:24 hannken Exp $ */ /*- * Copyright (c) 2007 The NetBSD Foundation, Inc. @@ -30,7 +30,7 @@ */ #include <sys/cdefs.h> -__KERNEL_RCSID(0, "$NetBSD: vfs_trans.c,v 1.55 2019/02/21 08:52:53 hannken Exp $"); +__KERNEL_RCSID(0, "$NetBSD: vfs_trans.c,v 1.56 2019/02/24 16:11:24 hannken Exp $"); /* * File system transaction operations. @@ -543,6 +543,9 @@ fstrans_done(struct mount *mp) return; } + if (__predict_false(fstrans_gone_count > 0)) + fstrans_clear_lwp_info(); + s = pserialize_read_enter(); if (__predict_true(fmi->fmi_state == FSTRANS_NORMAL)) { fli->fli_trans_cnt = 0; @@ -552,9 +555,6 @@ fstrans_done(struct mount *mp) } pserialize_read_exit(s); - if (__predict_false(fstrans_gone_count > 0)) - fstrans_clear_lwp_info(); - mutex_enter(&fstrans_lock); fli->fli_trans_cnt = 0; cv_signal(&fstrans_count_cv);