Module Name:    src
Committed By:   riastradh
Date:           Fri Dec  6 03:45:33 UTC 2019

Modified Files:
        src/sys/dev: cons.c

Log Message:
Fix reference count leak in cons(4).

Don't forget to vrele after you're done, folks!

XXX pullup-9
XXX pullup-8
XXX pullup-7
XXX pullup-6... 5... 4 might not have had this bug!


To generate a diff of this commit:
cvs rdiff -u -r1.75 -r1.76 src/sys/dev/cons.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/dev/cons.c
diff -u src/sys/dev/cons.c:1.75 src/sys/dev/cons.c:1.76
--- src/sys/dev/cons.c:1.75	Fri May 29 16:26:45 2015
+++ src/sys/dev/cons.c	Fri Dec  6 03:45:33 2019
@@ -1,4 +1,4 @@
-/*	$NetBSD: cons.c,v 1.75 2015/05/29 16:26:45 macallan Exp $	*/
+/*	$NetBSD: cons.c,v 1.76 2019/12/06 03:45:33 riastradh Exp $	*/
 
 /*
  * Copyright (c) 1988 University of Utah.
@@ -33,13 +33,13 @@
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  *
- * from: Utah $Hdr: cons.c 1.7 92/01/21$
+ * from: Utah $Hdr$
  *
  *	@(#)cons.c	8.2 (Berkeley) 1/12/94
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: cons.c,v 1.75 2015/05/29 16:26:45 macallan Exp $");
+__KERNEL_RCSID(0, "$NetBSD: cons.c,v 1.76 2019/12/06 03:45:33 riastradh Exp $");
 
 #include <sys/param.h>
 #include <sys/proc.h>
@@ -158,6 +158,7 @@ cnclose(dev_t dev, int flag, int mode, s
 	if (error == 0) {
 		error = VOP_CLOSE(vp, flag, kauth_cred_get());
 		VOP_UNLOCK(vp);
+		vrele(vp);
 	}
 	return error;
 }

Reply via email to