Module Name: src
Committed By: maxv
Date: Fri Dec 13 14:10:32 UTC 2019
Modified Files:
src/sys/dev/usb: if_urtwn.c
Log Message:
Fix gross use-after-free. Found by a custom query on LGTM.
To generate a diff of this commit:
cvs rdiff -u -r1.77 -r1.78 src/sys/dev/usb/if_urtwn.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/usb/if_urtwn.c
diff -u src/sys/dev/usb/if_urtwn.c:1.77 src/sys/dev/usb/if_urtwn.c:1.78
--- src/sys/dev/usb/if_urtwn.c:1.77 Sun Dec 1 21:02:09 2019
+++ src/sys/dev/usb/if_urtwn.c Fri Dec 13 14:10:32 2019
@@ -1,4 +1,4 @@
-/* $NetBSD: if_urtwn.c,v 1.77 2019/12/01 21:02:09 mlelstv Exp $ */
+/* $NetBSD: if_urtwn.c,v 1.78 2019/12/13 14:10:32 maxv Exp $ */
/* $OpenBSD: if_urtwn.c,v 1.42 2015/02/10 23:25:46 mpi Exp $ */
/*-
@@ -25,7 +25,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_urtwn.c,v 1.77 2019/12/01 21:02:09 mlelstv Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_urtwn.c,v 1.78 2019/12/13 14:10:32 maxv Exp $");
#ifdef _KERNEL_OPT
#include "opt_inet.h"
@@ -868,7 +868,6 @@ urtwn_task(void *arg)
}
if (urtwn_tx_beacon(sc, m, ic->ic_bss) != 0) {
- m_freem(m);
aprint_error_dev(sc->sc_dev, "could not send beacon");
}
