Module Name: src
Committed By: msaitoh
Date: Wed Feb 5 01:44:53 UTC 2020
Modified Files:
src/sys/dev/pci/ixgbe: ixgbe.c
Log Message:
Update comment in ixgbe_update_stats_counters() to clarify why we update
if_iqdrops and if_ierrors only. No functional change.
OK'd by knakahara and thorpej.
To generate a diff of this commit:
cvs rdiff -u -r1.223 -r1.224 src/sys/dev/pci/ixgbe/ixgbe.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/pci/ixgbe/ixgbe.c
diff -u src/sys/dev/pci/ixgbe/ixgbe.c:1.223 src/sys/dev/pci/ixgbe/ixgbe.c:1.224
--- src/sys/dev/pci/ixgbe/ixgbe.c:1.223 Tue Feb 4 19:42:55 2020
+++ src/sys/dev/pci/ixgbe/ixgbe.c Wed Feb 5 01:44:53 2020
@@ -1,4 +1,4 @@
-/* $NetBSD: ixgbe.c,v 1.223 2020/02/04 19:42:55 thorpej Exp $ */
+/* $NetBSD: ixgbe.c,v 1.224 2020/02/05 01:44:53 msaitoh Exp $ */
/******************************************************************************
@@ -1708,15 +1708,11 @@ ixgbe_update_stats_counters(struct adapt
stats->fcoedwtc.ev_count += IXGBE_READ_REG(hw, IXGBE_FCOEDWTC);
}
- /* Fill out the OS statistics structure */
/*
- * NetBSD: Don't override if_{i|o}{packets|bytes|mcasts} with
- * adapter->stats counters. It's required to make ifconfig -z
- * (SOICZIFDATA) work.
+ * Fill out the OS statistics structure. Only RX errors are required
+ * here because all TX counters are incremented in the TX path and
+ * normal RX counters are prepared in ether_input().
*/
- /* XXX Actually, just fill in the per-cpu stats, please !!! */
-
- /* Rx Errors */
net_stat_ref_t nsr = IF_STAT_GETREF(ifp);
if_statadd_ref(nsr, if_iqdrops, total_missed_rx);
if_statadd_ref(nsr, if_ierrors, crcerrs + rlec);
