Module Name:    src
Committed By:   ad
Date:           Tue Apr  7 19:12:25 UTC 2020

Modified Files:
        src/sys/uvm: uvm_bio.c

Log Message:
ubc_direct_release(): remove spurious call to uvm_pagemarkdirty().


To generate a diff of this commit:
cvs rdiff -u -r1.107 -r1.108 src/sys/uvm/uvm_bio.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/uvm/uvm_bio.c
diff -u src/sys/uvm/uvm_bio.c:1.107 src/sys/uvm/uvm_bio.c:1.108
--- src/sys/uvm/uvm_bio.c:1.107	Tue Apr  7 19:11:13 2020
+++ src/sys/uvm/uvm_bio.c	Tue Apr  7 19:12:25 2020
@@ -1,4 +1,4 @@
-/*	$NetBSD: uvm_bio.c,v 1.107 2020/04/07 19:11:13 ad Exp $	*/
+/*	$NetBSD: uvm_bio.c,v 1.108 2020/04/07 19:12:25 ad Exp $	*/
 
 /*
  * Copyright (c) 1998 Chuck Silvers.
@@ -34,7 +34,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: uvm_bio.c,v 1.107 2020/04/07 19:11:13 ad Exp $");
+__KERNEL_RCSID(0, "$NetBSD: uvm_bio.c,v 1.108 2020/04/07 19:12:25 ad Exp $");
 
 #include "opt_uvmhist.h"
 #include "opt_ubc.h"
@@ -914,17 +914,12 @@ ubc_direct_release(struct uvm_object *uo
 		uvm_pageactivate(pg);
 		uvm_pageunlock(pg);
 
-		/*
-		 * Page was changed, no longer fake and neither clean. 
-		 * There's no managed mapping in the direct case, so 
-		 * mark the page dirty manually.
-		 */
+		/* Page was changed, no longer fake and neither clean. */
 		if (flags & UBC_WRITE) {
 			pg->flags &= ~PG_FAKE;
 			KASSERTMSG(uvm_pagegetdirty(pg) ==
 			    UVM_PAGE_STATUS_DIRTY,
 			    "page %p not dirty", pg);
-			uvm_pagemarkdirty(pg, UVM_PAGE_STATUS_DIRTY);
 		}
 	}
 	uvm_page_unbusy(pgs, npages);

Reply via email to