Module Name: src
Committed By: rillig
Date: Sat Aug 1 15:13:45 UTC 2020
Modified Files:
src/usr.bin/make/unit-tests: varmod-edge.exp varmod-edge.mk
Log Message:
make(1): add test for empty modifier list after colon
This is a good candidate for becoming an error in strict mode.
Either write ${VAR} or write ${VAR:modifiers}, but not half-baked.
To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 src/usr.bin/make/unit-tests/varmod-edge.exp
cvs rdiff -u -r1.8 -r1.9 src/usr.bin/make/unit-tests/varmod-edge.mk
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/usr.bin/make/unit-tests/varmod-edge.exp
diff -u src/usr.bin/make/unit-tests/varmod-edge.exp:1.4 src/usr.bin/make/unit-tests/varmod-edge.exp:1.5
--- src/usr.bin/make/unit-tests/varmod-edge.exp:1.4 Mon Dec 2 01:01:08 2019
+++ src/usr.bin/make/unit-tests/varmod-edge.exp Sat Aug 1 15:13:45 2020
@@ -14,4 +14,5 @@ ok eq-ext
ok eq-q
ok eq-bs
ok eq-esc
+ok colon
exit status 0
Index: src/usr.bin/make/unit-tests/varmod-edge.mk
diff -u src/usr.bin/make/unit-tests/varmod-edge.mk:1.8 src/usr.bin/make/unit-tests/varmod-edge.mk:1.9
--- src/usr.bin/make/unit-tests/varmod-edge.mk:1.8 Sun Jul 19 16:08:24 2020
+++ src/usr.bin/make/unit-tests/varmod-edge.mk Sat Aug 1 15:13:45 2020
@@ -1,4 +1,4 @@
-# $NetBSD: varmod-edge.mk,v 1.8 2020/07/19 16:08:24 rillig Exp $
+# $NetBSD: varmod-edge.mk,v 1.9 2020/08/01 15:13:45 rillig Exp $
#
# Tests for edge cases in variable modifiers.
#
@@ -151,6 +151,11 @@ MOD.eq-esc= ${INP.eq-esc:a\=b}
EXP.eq-esc= # empty
# make: Unclosed substitution for INP.eq-esc (= missing)
+TESTS+= colon
+INP.colon= value
+MOD.colon= ${INP.colon:}
+EXP.colon= value
+
all:
.for test in ${TESTS}
. if ${MOD.${test}} == ${EXP.${test}}
