Module Name: src
Committed By: jakllsch
Date: Wed Sep 9 00:35:36 UTC 2020
Modified Files:
src/sys/dev/pci: if_iavf.c
Log Message:
fix bad conditional in iavf_parse_modprop()
found by clang
To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/sys/dev/pci/if_iavf.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/pci/if_iavf.c
diff -u src/sys/dev/pci/if_iavf.c:1.2 src/sys/dev/pci/if_iavf.c:1.3
--- src/sys/dev/pci/if_iavf.c:1.2 Tue Sep 8 13:28:51 2020
+++ src/sys/dev/pci/if_iavf.c Wed Sep 9 00:35:36 2020
@@ -1,4 +1,4 @@
-/* $NetBSD: if_iavf.c,v 1.2 2020/09/08 13:28:51 jakllsch Exp $ */
+/* $NetBSD: if_iavf.c,v 1.3 2020/09/09 00:35:36 jakllsch Exp $ */
/*
* Copyright (c) 2013-2015, Intel Corporation
@@ -75,7 +75,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_iavf.c,v 1.2 2020/09/08 13:28:51 jakllsch Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_iavf.c,v 1.3 2020/09/09 00:35:36 jakllsch Exp $");
#include <sys/param.h>
#include <sys/types.h>
@@ -5235,7 +5235,7 @@ iavf_parse_modprop(prop_dictionary_t dic
if (obj != NULL && prop_object_type(obj) == PROP_TYPE_NUMBER) {
val = prop_number_signed_value((prop_number_t)obj);
- if (val < 1 || I40E_MAX_VF_QUEUES) {
+ if (val < 1 || val > I40E_MAX_VF_QUEUES) {
printf("iavf: invalid queue size(1 <= n <= %d)",
I40E_MAX_VF_QUEUES);
} else {
