Module Name: src
Committed By: rillig
Date: Sun Sep 13 06:05:56 UTC 2020
Modified Files:
src/usr.bin/make: main.c parse.c
Log Message:
make(1): remove redundant VARARGS comments
These had been necessary at a time when the functions were declared with
"unknown parameter types".
On 1994-03-05, conditional support for function prototypes was added,
for those compilers that already supported this feature.
On 2002-06-15, the prototypes were made mandatory, and since then the
VARARGS comments had been completely redundant, or worse, simply wrong
(for ParseVErrorInternal).
To generate a diff of this commit:
cvs rdiff -u -r1.334 -r1.335 src/usr.bin/make/main.c
cvs rdiff -u -r1.295 -r1.296 src/usr.bin/make/parse.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/usr.bin/make/main.c
diff -u src/usr.bin/make/main.c:1.334 src/usr.bin/make/main.c:1.335
--- src/usr.bin/make/main.c:1.334 Sun Sep 13 05:56:32 2020
+++ src/usr.bin/make/main.c Sun Sep 13 06:05:56 2020
@@ -1,4 +1,4 @@
-/* $NetBSD: main.c,v 1.334 2020/09/13 05:56:32 rillig Exp $ */
+/* $NetBSD: main.c,v 1.335 2020/09/13 06:05:56 rillig Exp $ */
/*
* Copyright (c) 1988, 1989, 1990, 1993
@@ -69,7 +69,7 @@
*/
#ifndef MAKE_NATIVE
-static char rcsid[] = "$NetBSD: main.c,v 1.334 2020/09/13 05:56:32 rillig Exp $";
+static char rcsid[] = "$NetBSD: main.c,v 1.335 2020/09/13 06:05:56 rillig Exp $";
#else
#include <sys/cdefs.h>
#ifndef lint
@@ -81,7 +81,7 @@ __COPYRIGHT("@(#) Copyright (c) 1988, 19
#if 0
static char sccsid[] = "@(#)main.c 8.3 (Berkeley) 3/19/94";
#else
-__RCSID("$NetBSD: main.c,v 1.334 2020/09/13 05:56:32 rillig Exp $");
+__RCSID("$NetBSD: main.c,v 1.335 2020/09/13 06:05:56 rillig Exp $");
#endif
#endif /* not lint */
#endif
@@ -1703,7 +1703,6 @@ bad:
* Side Effects:
* The message is printed.
*/
-/* VARARGS */
void
Error(const char *fmt, ...)
{
@@ -1730,7 +1729,6 @@ Error(const char *fmt, ...)
/* Produce a Fatal error message, then exit immediately.
*
* If jobs are running, waits for them to finish. */
-/* VARARGS */
void
Fatal(const char *fmt, ...)
{
@@ -1765,7 +1763,6 @@ Fatal(const char *fmt, ...)
* Side Effects:
* All children are killed indiscriminately and the program Lib_Exits
*/
-/* VARARGS */
void
Punt(const char *fmt, ...)
{
Index: src/usr.bin/make/parse.c
diff -u src/usr.bin/make/parse.c:1.295 src/usr.bin/make/parse.c:1.296
--- src/usr.bin/make/parse.c:1.295 Sat Sep 12 19:41:20 2020
+++ src/usr.bin/make/parse.c Sun Sep 13 06:05:56 2020
@@ -1,4 +1,4 @@
-/* $NetBSD: parse.c,v 1.295 2020/09/12 19:41:20 rillig Exp $ */
+/* $NetBSD: parse.c,v 1.296 2020/09/13 06:05:56 rillig Exp $ */
/*
* Copyright (c) 1988, 1989, 1990, 1993
@@ -69,14 +69,14 @@
*/
#ifndef MAKE_NATIVE
-static char rcsid[] = "$NetBSD: parse.c,v 1.295 2020/09/12 19:41:20 rillig Exp $";
+static char rcsid[] = "$NetBSD: parse.c,v 1.296 2020/09/13 06:05:56 rillig Exp $";
#else
#include <sys/cdefs.h>
#ifndef lint
#if 0
static char sccsid[] = "@(#)parse.c 8.3 (Berkeley) 3/19/94";
#else
-__RCSID("$NetBSD: parse.c,v 1.295 2020/09/12 19:41:20 rillig Exp $");
+__RCSID("$NetBSD: parse.c,v 1.296 2020/09/13 06:05:56 rillig Exp $");
#endif
#endif /* not lint */
#endif
@@ -659,7 +659,6 @@ PrintLocation(FILE *f, const char *cfnam
* Side Effects:
* "fatals" is incremented if the level is PARSE_FATAL.
*/
-/* VARARGS */
static void
ParseVErrorInternal(FILE *f, const char *cfname, size_t clineno, int type,
const char *fmt, va_list ap)
@@ -695,7 +694,6 @@ ParseVErrorInternal(FILE *f, const char
* Side Effects:
* None
*/
-/* VARARGS */
static void
ParseErrorInternal(const char *cfname, size_t clineno, int type,
const char *fmt, ...)
@@ -718,7 +716,6 @@ ParseErrorInternal(const char *cfname, s
* line number.
*
* Fmt is given without a trailing newline. */
-/* VARARGS */
void
Parse_Error(int type, const char *fmt, ...)
{
