Module Name:    src
Committed By:   rillig
Date:           Sat Nov  7 14:18:26 UTC 2020

Modified Files:
        src/usr.bin/make: compat.c

Log Message:
make(1): replace switch with if-else chain in Compat_RunCommand


To generate a diff of this commit:
cvs rdiff -u -r1.176 -r1.177 src/usr.bin/make/compat.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/usr.bin/make/compat.c
diff -u src/usr.bin/make/compat.c:1.176 src/usr.bin/make/compat.c:1.177
--- src/usr.bin/make/compat.c:1.176	Sat Nov  7 10:23:20 2020
+++ src/usr.bin/make/compat.c	Sat Nov  7 14:18:25 2020
@@ -1,4 +1,4 @@
-/*	$NetBSD: compat.c,v 1.176 2020/11/07 10:23:20 rillig Exp $	*/
+/*	$NetBSD: compat.c,v 1.177 2020/11/07 14:18:25 rillig Exp $	*/
 
 /*
  * Copyright (c) 1988, 1989, 1990 The Regents of the University of California.
@@ -96,7 +96,7 @@
 #include "pathnames.h"
 
 /*	"@(#)compat.c	8.2 (Berkeley) 3/19/94"	*/
-MAKE_RCSID("$NetBSD: compat.c,v 1.176 2020/11/07 10:23:20 rillig Exp $");
+MAKE_RCSID("$NetBSD: compat.c,v 1.177 2020/11/07 14:18:25 rillig Exp $");
 
 static GNode *curTarg = NULL;
 static pid_t compatChild;
@@ -220,20 +220,17 @@ Compat_RunCommand(const char *cmdp, GNod
 	return 0;
     }
 
-    while (*cmd == '@' || *cmd == '-' || *cmd == '+') {
-	switch (*cmd) {
-	case '@':
+    for (;;) {
+	if (*cmd == '@')
 	    silent = !DEBUG(LOUD);
-	    break;
-	case '-':
+	else if (*cmd == '-')
 	    errCheck = FALSE;
-	    break;
-	case '+':
+	else if (*cmd == '+') {
 	    doIt = TRUE;
-	    if (!shellName)		/* we came here from jobs */
+	    if (!shellName)	/* we came here from jobs */
 		Shell_Init();
+	} else
 	    break;
-	}
 	cmd++;
     }
 

Reply via email to