Module Name: src
Committed By: rillig
Date: Tue Jan 19 19:54:57 UTC 2021
Modified Files:
src/usr.bin/make/unit-tests: cond-cmp-string.exp cond-cmp-string.mk
Log Message:
make(1): add test for unsupported relational string comparisons
To generate a diff of this commit:
cvs rdiff -u -r1.8 -r1.9 src/usr.bin/make/unit-tests/cond-cmp-string.exp
cvs rdiff -u -r1.13 -r1.14 src/usr.bin/make/unit-tests/cond-cmp-string.mk
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/usr.bin/make/unit-tests/cond-cmp-string.exp
diff -u src/usr.bin/make/unit-tests/cond-cmp-string.exp:1.8 src/usr.bin/make/unit-tests/cond-cmp-string.exp:1.9
--- src/usr.bin/make/unit-tests/cond-cmp-string.exp:1.8 Sun Nov 15 14:07:53 2020
+++ src/usr.bin/make/unit-tests/cond-cmp-string.exp Tue Jan 19 19:54:57 2021
@@ -3,6 +3,14 @@ make: "cond-cmp-string.mk" line 42: Malf
make: "cond-cmp-string.mk" line 49: warning: String comparison operator must be either == or !=
make: "cond-cmp-string.mk" line 49: Malformed conditional (!("value" = "value"))
make: "cond-cmp-string.mk" line 56: Malformed conditional (!("value" === "value"))
+make: "cond-cmp-string.mk" line 113: warning: String comparison operator must be either == or !=
+make: "cond-cmp-string.mk" line 113: Malformed conditional ("string" < "string")
+make: "cond-cmp-string.mk" line 120: warning: String comparison operator must be either == or !=
+make: "cond-cmp-string.mk" line 120: Malformed conditional ("string" <= "string")
+make: "cond-cmp-string.mk" line 127: warning: String comparison operator must be either == or !=
+make: "cond-cmp-string.mk" line 127: Malformed conditional ("string" > "string")
+make: "cond-cmp-string.mk" line 134: warning: String comparison operator must be either == or !=
+make: "cond-cmp-string.mk" line 134: Malformed conditional ("string" >= "string")
make: Fatal errors encountered -- cannot continue
make: stopped in unit-tests
exit status 1
Index: src/usr.bin/make/unit-tests/cond-cmp-string.mk
diff -u src/usr.bin/make/unit-tests/cond-cmp-string.mk:1.13 src/usr.bin/make/unit-tests/cond-cmp-string.mk:1.14
--- src/usr.bin/make/unit-tests/cond-cmp-string.mk:1.13 Sun Nov 15 14:07:53 2020
+++ src/usr.bin/make/unit-tests/cond-cmp-string.mk Tue Jan 19 19:54:57 2021
@@ -1,4 +1,4 @@
-# $NetBSD: cond-cmp-string.mk,v 1.13 2020/11/15 14:07:53 rillig Exp $
+# $NetBSD: cond-cmp-string.mk,v 1.14 2021/01/19 19:54:57 rillig Exp $
#
# Tests for string comparisons in .if conditions.
@@ -108,3 +108,31 @@
.if 12345.0 == "12345"
. error
.endif
+
+# Strings cannot be compared relationally, only for equality.
+.if "string" < "string"
+. error
+.else
+. error
+.endif
+
+# Strings cannot be compared relationally, only for equality.
+.if "string" <= "string"
+. error
+.else
+. error
+.endif
+
+# Strings cannot be compared relationally, only for equality.
+.if "string" > "string"
+. error
+.else
+. error
+.endif
+
+# Strings cannot be compared relationally, only for equality.
+.if "string" >= "string"
+. error
+.else
+. error
+.endif
