Module Name: src
Committed By: reinoud
Date: Sun Jan 24 15:59:35 UTC 2021
Modified Files:
src/sys/dev/pci: virtio_pci.c
Log Message:
Remove incorrect comment. It would violate the specs.
VirtIO PCI v1.0 attachments can only happen on revision 1 devices as they have
a radical different register layout. Transitional devices have to use revision
0 and have to use the VirtIO PCI v0.9 attachment method but can allow for
features to be negotiated normally found in later versions.
To generate a diff of this commit:
cvs rdiff -u -r1.24 -r1.25 src/sys/dev/pci/virtio_pci.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/pci/virtio_pci.c
diff -u src/sys/dev/pci/virtio_pci.c:1.24 src/sys/dev/pci/virtio_pci.c:1.25
--- src/sys/dev/pci/virtio_pci.c:1.24 Sun Jan 24 15:34:07 2021
+++ src/sys/dev/pci/virtio_pci.c Sun Jan 24 15:59:35 2021
@@ -1,4 +1,4 @@
-/* $NetBSD: virtio_pci.c,v 1.24 2021/01/24 15:34:07 thorpej Exp $ */
+/* $NetBSD: virtio_pci.c,v 1.25 2021/01/24 15:59:35 reinoud Exp $ */
/*
* Copyright (c) 2020 The NetBSD Foundation, Inc.
@@ -28,7 +28,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: virtio_pci.c,v 1.24 2021/01/24 15:34:07 thorpej Exp $");
+__KERNEL_RCSID(0, "$NetBSD: virtio_pci.c,v 1.25 2021/01/24 15:59:35 reinoud Exp $");
#include <sys/param.h>
#include <sys/systm.h>
@@ -461,12 +461,6 @@ virtio_pci_attach_10(device_t self, void
else
have_device_cfg = 1;
- /*
- * XXX Maybe there are devices that offer the pci caps but not the
- * XXX VERSION_1 feature bit? Then we should check the feature bit
- * XXX here and fall back to 0.9 out if not present.
- */
-
/* Figure out which bars we need to map */
for (i = 0; i < __arraycount(caps); i++) {
int bar = caps[i]->bar;
