Module Name: src
Committed By: rillig
Date: Tue Feb 16 19:43:09 UTC 2021
Modified Files:
src/usr.bin/make/unit-tests: varcmd.mk
Log Message:
make: document the bad state in which the test varcmd.mk is
To generate a diff of this commit:
cvs rdiff -u -r1.5 -r1.6 src/usr.bin/make/unit-tests/varcmd.mk
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/usr.bin/make/unit-tests/varcmd.mk
diff -u src/usr.bin/make/unit-tests/varcmd.mk:1.5 src/usr.bin/make/unit-tests/varcmd.mk:1.6
--- src/usr.bin/make/unit-tests/varcmd.mk:1.5 Sat Oct 24 08:50:17 2020
+++ src/usr.bin/make/unit-tests/varcmd.mk Tue Feb 16 19:43:09 2021
@@ -1,6 +1,17 @@
-# $NetBSD: varcmd.mk,v 1.5 2020/10/24 08:50:17 rillig Exp $
+# $NetBSD: varcmd.mk,v 1.6 2021/02/16 19:43:09 rillig Exp $
#
# Test behaviour of recursive make and vars set on command line.
+#
+# FIXME: The purpose of this test is unclear. The test uses six levels of
+# sub-makes, which makes it incredibly hard to understand. There must be at
+# least an introductory explanation about what _should_ happen here.
+# The variable names are terrible, as well as their values.
+#
+# This test produces different results if the large block with the condition
+# "scope == SCOPE_GLOBAL" in Var_SetWithFlags is removed. This test should
+# be rewritten to make it clear why there is a difference and why this is
+# actually intended. Removing that large block of code makes only this test
+# and vardebug.mk fail, which is not enough.
FU= fu
FOO?= foo
@@ -57,4 +68,3 @@ five: show show-v
six: show-v
@${.MAKE} -f ${MAKEFILE} V=override show-v
-
