Module Name:    src
Committed By:   rillig
Date:           Tue Mar 23 23:12:21 UTC 2021

Modified Files:
        src/tests/usr.bin/xlint/lint1: d_c99_bool_strict.c d_c99_init.c
            d_c99_init.exp

Log Message:
tests/lint: fix outdated comments


To generate a diff of this commit:
cvs rdiff -u -r1.26 -r1.27 src/tests/usr.bin/xlint/lint1/d_c99_bool_strict.c
cvs rdiff -u -r1.12 -r1.13 src/tests/usr.bin/xlint/lint1/d_c99_init.c
cvs rdiff -u -r1.10 -r1.11 src/tests/usr.bin/xlint/lint1/d_c99_init.exp

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/tests/usr.bin/xlint/lint1/d_c99_bool_strict.c
diff -u src/tests/usr.bin/xlint/lint1/d_c99_bool_strict.c:1.26 src/tests/usr.bin/xlint/lint1/d_c99_bool_strict.c:1.27
--- src/tests/usr.bin/xlint/lint1/d_c99_bool_strict.c:1.26	Sun Mar 21 14:36:59 2021
+++ src/tests/usr.bin/xlint/lint1/d_c99_bool_strict.c	Tue Mar 23 23:12:21 2021
@@ -1,4 +1,4 @@
-/*	$NetBSD: d_c99_bool_strict.c,v 1.26 2021/03/21 14:36:59 rillig Exp $	*/
+/*	$NetBSD: d_c99_bool_strict.c,v 1.27 2021/03/23 23:12:21 rillig Exp $	*/
 # 3 "d_c99_bool_strict.c"
 
 /*
@@ -151,10 +151,10 @@ enum strict_bool_constant_expressions {
 	/*
 	 * Without strict bool mode, these two variants of an expression can
 	 * occur when a preprocessor macro is either defined to 1 or left
-	 * empty, as in lint1/ops.def.
+	 * empty (since C99), as in lint1/ops.def.
 	 *
-	 * TODO: figure out an elegant way to achieve the same effect in
-	 *  strict bool mode.
+	 * In strict bool mode, the resulting expression can be compared
+	 * against 0 to achieve the same effect (so +0 != 0 or 1 + 0 != 0).
 	 */
 	BINARY_PLUS = (1 + 0) ? 100 : 101, /* expect: 331 */
 	UNARY_PLUS = (+0) ? 100 : 101,	/* expect: 331 */

Index: src/tests/usr.bin/xlint/lint1/d_c99_init.c
diff -u src/tests/usr.bin/xlint/lint1/d_c99_init.c:1.12 src/tests/usr.bin/xlint/lint1/d_c99_init.c:1.13
--- src/tests/usr.bin/xlint/lint1/d_c99_init.c:1.12	Sat Mar 20 08:59:46 2021
+++ src/tests/usr.bin/xlint/lint1/d_c99_init.c	Tue Mar 23 23:12:21 2021
@@ -1,4 +1,4 @@
-/*	$NetBSD: d_c99_init.c,v 1.12 2021/03/20 08:59:46 rillig Exp $	*/
+/*	$NetBSD: d_c99_init.c,v 1.13 2021/03/23 23:12:21 rillig Exp $	*/
 # 3 "d_c99_init.c"
 
 /*
@@ -47,7 +47,6 @@ void
 initialization_with_redundant_braces(any arg)
 {
 	any local = { arg };	/* expect: 185 */
-	// TODO: message 185 needs to be reworded to "cannot initialize '%s' from '%s'".
 	use(&arg);
 }
 

Index: src/tests/usr.bin/xlint/lint1/d_c99_init.exp
diff -u src/tests/usr.bin/xlint/lint1/d_c99_init.exp:1.10 src/tests/usr.bin/xlint/lint1/d_c99_init.exp:1.11
--- src/tests/usr.bin/xlint/lint1/d_c99_init.exp:1.10	Sun Mar 21 20:44:59 2021
+++ src/tests/usr.bin/xlint/lint1/d_c99_init.exp	Tue Mar 23 23:12:21 2021
@@ -1,6 +1,6 @@
 d_c99_init.c(22): error: invalid initializer type int [176]
 d_c99_init.c(23): error: too many initializers [174]
 d_c99_init.c(49): error: cannot initialize 'pointer to const void' from 'struct any' [185]
-d_c99_init.c(66): error: too many array initializers, expected 3 [173]
-d_c99_init.c(131): error: syntax error 'named member must only be used with struct/union' [249]
-d_c99_init.c(143): error: invalid initializer type int [176]
+d_c99_init.c(65): error: too many array initializers, expected 3 [173]
+d_c99_init.c(130): error: syntax error 'named member must only be used with struct/union' [249]
+d_c99_init.c(142): error: invalid initializer type int [176]

Reply via email to