Module Name: src
Committed By: rillig
Date: Thu Apr 15 18:21:27 UTC 2021
Modified Files:
src/usr.bin/make: job.c
Log Message:
make: document two previously unknown bugs in job mode
To generate a diff of this commit:
cvs rdiff -u -r1.424 -r1.425 src/usr.bin/make/job.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/usr.bin/make/job.c
diff -u src/usr.bin/make/job.c:1.424 src/usr.bin/make/job.c:1.425
--- src/usr.bin/make/job.c:1.424 Sun Apr 4 10:05:08 2021
+++ src/usr.bin/make/job.c Thu Apr 15 18:21:27 2021
@@ -1,4 +1,4 @@
-/* $NetBSD: job.c,v 1.424 2021/04/04 10:05:08 rillig Exp $ */
+/* $NetBSD: job.c,v 1.425 2021/04/15 18:21:27 rillig Exp $ */
/*
* Copyright (c) 1988, 1989, 1990 The Regents of the University of California.
@@ -142,7 +142,7 @@
#include "trace.h"
/* "@(#)job.c 8.2 (Berkeley) 3/19/94" */
-MAKE_RCSID("$NetBSD: job.c,v 1.424 2021/04/04 10:05:08 rillig Exp $");
+MAKE_RCSID("$NetBSD: job.c,v 1.425 2021/04/15 18:21:27 rillig Exp $");
/*
* A shell defines how the commands are run. All commands for a target are
@@ -1834,7 +1834,9 @@ again:
break;
} else if (job->outBuf[i] == '\0') {
/*
- * Why?
+ * FIXME: The null characters are only replaced with
+ * space in the last line. Everywhere else they hide
+ * the rest of the command output.
*/
job->outBuf[i] = ' ';
}
@@ -1866,6 +1868,12 @@ again:
if (i >= job->curPos) {
char *cp;
+ /*
+ * FIXME: SwitchOutputTo should be here, according to
+ * the comment above. But since PrintOutput does not
+ * do anything in the default shell, this bug has gone
+ * unnoticed until now.
+ */
cp = PrintOutput(job->outBuf, &job->outBuf[i]);
/*
