Module Name: xsrc
Committed By: rillig
Date: Fri May 21 19:09:50 UTC 2021
Modified Files:
xsrc/external/mit/xf86-video-nv/dist/src: nv_setup.c
Log Message:
xf86-video-nv: fix Clang build on amd64, i386, macppc
xsrc/external/mit/xf86-video-nv/dist/src/nv_setup.c:258:49: error:
passing 'char *' to parameter of type 'Uchar *' (aka 'unsigned char *')
converts between pointers to integer types with different sign
[-Werror,-Wpointer-sign]
tmp = xf86InterpretEEDID(pScrn->scrnIndex, buffer);
^~~~~~
To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 xsrc/external/mit/xf86-video-nv/dist/src/nv_setup.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: xsrc/external/mit/xf86-video-nv/dist/src/nv_setup.c
diff -u xsrc/external/mit/xf86-video-nv/dist/src/nv_setup.c:1.2 xsrc/external/mit/xf86-video-nv/dist/src/nv_setup.c:1.3
--- xsrc/external/mit/xf86-video-nv/dist/src/nv_setup.c:1.2 Thu Mar 25 17:22:02 2021
+++ xsrc/external/mit/xf86-video-nv/dist/src/nv_setup.c Fri May 21 19:09:50 2021
@@ -246,10 +246,10 @@ NVProbeDDC (ScrnInfoPtr pScrn, int bus)
if (!MonInfo) {
/* ask wsdisplay */
struct wsdisplayio_edid_info ei;
- char *buffer;
+ Uchar *buffer;
xf86MonPtr tmp;
- buffer = malloc(1024);
+ buffer = malloc(1024); /* XXX: missing null check */
ei.edid_data = buffer;
ei.buffer_size = 1024;
if (ioctl(xf86Info.consoleFd, WSDISPLAYIO_GET_EDID, &ei) != -1) {
