Module Name:    src
Committed By:   rillig
Date:           Wed Jun 30 14:32:41 UTC 2021

Modified Files:
        src/tests/usr.bin/xlint/lint1: msg_155.exp msg_215.c msg_215.exp
        src/usr.bin/xlint/lint1: tree.c

Log Message:
lint: in C99 mode, only warn about implicit function declarations

Since tree.c 1.294 from 2021-06-28 (two days ago), lint errored out on
an implicit function declaration.  In principle it is correct to do so
since C99 requires it, but in practice there are a several functions
that are not declared in the translation unit itself since they are
provided by the compiler.  Typical examples for GCC and Clang are the
various functions named '__builtin_*' and '__atomic_*'.

For now, only warn about these but don't error out.


To generate a diff of this commit:
cvs rdiff -u -r1.9 -r1.10 src/tests/usr.bin/xlint/lint1/msg_155.exp
cvs rdiff -u -r1.7 -r1.8 src/tests/usr.bin/xlint/lint1/msg_215.c \
    src/tests/usr.bin/xlint/lint1/msg_215.exp
cvs rdiff -u -r1.301 -r1.302 src/usr.bin/xlint/lint1/tree.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/tests/usr.bin/xlint/lint1/msg_155.exp
diff -u src/tests/usr.bin/xlint/lint1/msg_155.exp:1.9 src/tests/usr.bin/xlint/lint1/msg_155.exp:1.10
--- src/tests/usr.bin/xlint/lint1/msg_155.exp:1.9	Wed Jun 30 14:23:50 2021
+++ src/tests/usr.bin/xlint/lint1/msg_155.exp	Wed Jun 30 14:32:41 2021
@@ -3,7 +3,7 @@ msg_155.c(28): warning: passing 'struct 
 msg_155.c(32): warning: passing 'struct incompatible' to incompatible 'pointer to pointer to int', arg #1 [155]
 msg_155.c(35): warning: passing 'struct incompatible' to incompatible 'pointer to array[3] of int', arg #1 [155]
 msg_155.c(38): warning: passing 'struct incompatible' to incompatible 'pointer to array[unknown_size] of int', arg #1 [155]
-msg_155.c(42): error: function 'c99_6_7_6_example_f' implicitly declared to return int [215]
+msg_155.c(42): warning: function 'c99_6_7_6_example_f' implicitly declared to return int [215]
 msg_155.c(45): warning: passing 'struct incompatible' to incompatible 'pointer to function(void) returning int', arg #1 [155]
 msg_155.c(48): warning: passing 'struct incompatible' to incompatible 'pointer to const pointer to function(unsigned int, ...) returning int', arg #1 [155]
 msg_155.c(69): warning: passing 'enum Day' to incompatible 'struct incompatible', arg #1 [155]

Index: src/tests/usr.bin/xlint/lint1/msg_215.c
diff -u src/tests/usr.bin/xlint/lint1/msg_215.c:1.7 src/tests/usr.bin/xlint/lint1/msg_215.c:1.8
--- src/tests/usr.bin/xlint/lint1/msg_215.c:1.7	Wed Jun 30 14:23:50 2021
+++ src/tests/usr.bin/xlint/lint1/msg_215.c	Wed Jun 30 14:32:41 2021
@@ -1,4 +1,4 @@
-/*	$NetBSD: msg_215.c,v 1.7 2021/06/30 14:23:50 rillig Exp $	*/
+/*	$NetBSD: msg_215.c,v 1.8 2021/06/30 14:32:41 rillig Exp $	*/
 # 3 "msg_215.c"
 
 // Test for message: function '%s' implicitly declared to return int [215]
@@ -17,7 +17,7 @@ struct str {
 void
 test(struct str str)
 {
-	/* expect+1: error: function 'name' implicitly declared to return int [215] */
+	/* expect+1: warning: function 'name' implicitly declared to return int [215] */
 	name();
 
 	/* expect+2: error: 'parenthesized' undefined [99] */
Index: src/tests/usr.bin/xlint/lint1/msg_215.exp
diff -u src/tests/usr.bin/xlint/lint1/msg_215.exp:1.7 src/tests/usr.bin/xlint/lint1/msg_215.exp:1.8
--- src/tests/usr.bin/xlint/lint1/msg_215.exp:1.7	Wed Jun 30 14:23:50 2021
+++ src/tests/usr.bin/xlint/lint1/msg_215.exp	Wed Jun 30 14:32:41 2021
@@ -1,4 +1,4 @@
-msg_215.c(21): error: function 'name' implicitly declared to return int [215]
+msg_215.c(21): warning: function 'name' implicitly declared to return int [215]
 msg_215.c(25): error: 'parenthesized' undefined [99]
 msg_215.c(25): error: illegal function (type int) [149]
 msg_215.c(29): error: type 'struct str' does not have member 'member' [101]

Index: src/usr.bin/xlint/lint1/tree.c
diff -u src/usr.bin/xlint/lint1/tree.c:1.301 src/usr.bin/xlint/lint1/tree.c:1.302
--- src/usr.bin/xlint/lint1/tree.c:1.301	Wed Jun 30 14:23:50 2021
+++ src/usr.bin/xlint/lint1/tree.c	Wed Jun 30 14:32:41 2021
@@ -1,4 +1,4 @@
-/*	$NetBSD: tree.c,v 1.301 2021/06/30 14:23:50 rillig Exp $	*/
+/*	$NetBSD: tree.c,v 1.302 2021/06/30 14:32:41 rillig Exp $	*/
 
 /*
  * Copyright (c) 1994, 1995 Jochen Pohl
@@ -37,7 +37,7 @@
 
 #include <sys/cdefs.h>
 #if defined(__RCSID) && !defined(lint)
-__RCSID("$NetBSD: tree.c,v 1.301 2021/06/30 14:23:50 rillig Exp $");
+__RCSID("$NetBSD: tree.c,v 1.302 2021/06/30 14:32:41 rillig Exp $");
 #endif
 
 #include <float.h>
@@ -247,7 +247,7 @@ new_name_node(sym_t *sym, int follow_tok
 		if (follow_token == T_LPAREN) {
 			if (Sflag) {
 				/* function '%s' implicitly declared to ... */
-				error(215, sym->s_name);
+				warning(215, sym->s_name);
 			} else if (sflag) {
 				/* function '%s' implicitly declared to ... */
 				warning(215, sym->s_name);

Reply via email to