Module Name: src
Committed By: pooka
Date: Tue May 25 11:02:07 UTC 2010
Modified Files:
src/sys/ufs/ufs: ufs_wapbl.c
Log Message:
Add a comment describing an observed boom-crash-burn problem in
the code. Fixing it will require a full tank of gas, half a pack
of cigarettes, sunglasses, darkness, and most importantly:
someone else.
To generate a diff of this commit:
cvs rdiff -u -r1.8 -r1.9 src/sys/ufs/ufs/ufs_wapbl.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/ufs/ufs/ufs_wapbl.c
diff -u src/sys/ufs/ufs/ufs_wapbl.c:1.8 src/sys/ufs/ufs/ufs_wapbl.c:1.9
--- src/sys/ufs/ufs/ufs_wapbl.c:1.8 Tue Mar 2 14:45:55 2010
+++ src/sys/ufs/ufs/ufs_wapbl.c Tue May 25 11:02:07 2010
@@ -1,4 +1,4 @@
-/* $NetBSD: ufs_wapbl.c,v 1.8 2010/03/02 14:45:55 pooka Exp $ */
+/* $NetBSD: ufs_wapbl.c,v 1.9 2010/05/25 11:02:07 pooka Exp $ */
/*-
* Copyright (c) 2003,2006,2008 The NetBSD Foundation, Inc.
@@ -66,7 +66,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ufs_wapbl.c,v 1.8 2010/03/02 14:45:55 pooka Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ufs_wapbl.c,v 1.9 2010/05/25 11:02:07 pooka Exp $");
#include <sys/param.h>
#include <sys/systm.h>
@@ -371,6 +371,10 @@
error = ENOENT; /* XXX ufs_rename sets "0" here */
goto out2;
}
+ /*
+ * XXX: if fvp != a_fvp, a_fvp can now have 0 references and yet we
+ * access a_fvp->inode via ip later. boom.
+ */
vrele(ap->a_fvp);
/* save directory lookup information in case tdvp == fdvp */
