Module Name:    src
Committed By:   dholland
Date:           Sun Sep 26 21:12:24 UTC 2010

Modified Files:
        src/games/monop: cards.c

Log Message:
Avoid undefined behavior, from Chris Spiegel in PR 43860.


To generate a diff of this commit:
cvs rdiff -u -r1.23 -r1.24 src/games/monop/cards.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/games/monop/cards.c
diff -u src/games/monop/cards.c:1.23 src/games/monop/cards.c:1.24
--- src/games/monop/cards.c:1.23	Sun Feb 24 03:56:48 2008
+++ src/games/monop/cards.c	Sun Sep 26 21:12:23 2010
@@ -1,4 +1,4 @@
-/*	$NetBSD: cards.c,v 1.23 2008/02/24 03:56:48 christos Exp $	*/
+/*	$NetBSD: cards.c,v 1.24 2010/09/26 21:12:23 dholland Exp $	*/
 
 /*
  * Copyright (c) 1980, 1993
@@ -34,7 +34,7 @@
 #if 0
 static char sccsid[] = "@(#)cards.c	8.1 (Berkeley) 5/31/93";
 #else
-__RCSID("$NetBSD: cards.c,v 1.23 2008/02/24 03:56:48 christos Exp $");
+__RCSID("$NetBSD: cards.c,v 1.24 2010/09/26 21:12:23 dholland Exp $");
 #endif
 #endif /* not lint */
 
@@ -247,7 +247,7 @@
 	do {
 		thiscard = &dp->info[dp->top_card];
 		type_maj = thiscard->actioncode[0];
-		dp->top_card = ++(dp->top_card) % dp->num_cards;
+		dp->top_card = (dp->top_card + 1) % dp->num_cards;
 	} while (dp->gojf_used && type_maj == GOJF);
 	type_min = thiscard->actioncode[1];
 	num = atoi(thiscard->actioncode+2);

Reply via email to